[Bug]: macOS Touch Bar shows the secret typed into the request card as QuickType suggestions after Save

Abierto
  • ¿Algo no está bien?
#35,147 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
57/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
macos, react, typescript
Área
desktop, security

Línea de trabajo

Start with apps/web and inspect SecretRequestCard.tsx, especially how the focused password field is handled when Save is pressed and when the request succeeds. Reproduce on macOS with a Touch Bar using the listed steps, then check whether the value remains protected until it is cleared. Done means saving a secret no longer exposes it as QuickType suggestions or learned text.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Before submitting
  • I searched existing issues and did not find a duplicate.
  • I included enough detail to reproduce or investigate the problem.
Area

apps/web

Steps to reproduce
  1. On macOS with a Touch Bar, have an agent call request_secret (no secret source selected, so the card shows the masked field).
  2. Type a throwaway value, e.g. touchbartest. The Touch Bar shows nothing while typing.
  3. Press Save securely.
Expected behavior

The typed value is never exposed outside the masked field. No QuickType candidates for it on the Touch Bar, and macOS does not learn it as a word.

Actual behavior

Right after Save, the Touch Bar shows QuickType suggestions containing the secret: "touchbartest" and Touchbartest. The value is saved correctly. It is only exposed in the moment after Save, never while typing.

macOS only offers QuickType candidates for non-secure text input, so Secure Input appears to be dropped while the value is still in the field. macOS may also add the value to its learned words.

Suspected cause (not verified): SecretRequestCard.tsx sets disabled={submitting} on the focused type="password" input on submit. The value is only cleared after the request succeeds. Disabling the focused password field may end Secure Input while the text is still there. Keeping the field enabled (e.g. readOnly) during submit, or clearing it before disabling, might avoid this.

Possibly related, opposite direction: #22449.

Impact

Major degradation or frequent failure

Version or commit

0.1.10-nightly.20261112.4564

Environment

macOS desktop app (Nightly), MacBook with Touch Bar

Screenshots

Touch Bar right after pressing Save.

image
Workaround

None, apart from typing secrets on a Mac without a Touch Bar. It is unclear whether QuickType still learns the word there.

Lenguaje dominante
TypeScript
Estrellas
24.8k
Forks
6.4k
Merge medio
4 h 16 min
PR fusionados (30 d)
352

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de pingdotgg/t3code

Todos los issues de pingdotgg/t3code

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.