The types for `Permission` are not as in the API.

Aberta
#756 0 comentários 1 reação 0 responsáveis Ver no GitHub

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
2/5
Tempo estimado
1-3 horas
Facilidade para iniciantes
48/100
Tipo de issue
Bug
Clareza
Razoavelmente clara
Status de atividade
Estagnada
Stack de tecnologia
typescript
Domínio
api

Direção de pesquisa

Start by locating the beta Permission and SharePointIdentitySet type definitions, then compare grantedToV2 with the documented response and the reported Graph API response. Update the type to match the evidence and check the relevant generated or type validation tests; done means the definition accepts the reported grantedToV2 shape and remains consistent with the API documentation.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

status:waiting-for-triage type:bug
Describe the bug

The response for https://learn.microsoft.com/en-us/graph/api/filestoragecontainer-list-permissions?view=graph-rest-beta&tabs=http#response should be of type permission.

The type permission is described in the BETA package as:

export interface Permission extends Entity {
    /**
     * A format of yyyy-MM-ddTHH:mm:ssZ of DateTimeOffset indicates the expiration time of the permission. DateTime.MinValue
     * indicates there's no expiration set for this permission. Optional.
     */
    expirationDateTime?: NullableOption<string>;
    // For user type permissions, the details of the users and applications for this permission. Read-only.
    grantedTo?: NullableOption<IdentitySet>;
    // For type permissions, the details of the users to whom permission was granted. Read-only.
    grantedToIdentities?: NullableOption<IdentitySet[]>;
    // For link type permissions, the details of the users to whom permission was granted. Read-only.
    grantedToIdentitiesV2?: NullableOption<SharePointIdentitySet[]>;
    // For user type permissions, the details of the users and applications for this permission. Read-only.
    grantedToV2?: NullableOption<SharePointIdentitySet>;
    /**
     * Indicates whether the password is set for this permission. This property only appears in the response. Optional.
     * Read-only. For OneDrive Personal only.
     */
    hasPassword?: NullableOption<boolean>;
    // Provides a reference to the ancestor of the current permission, if it's inherited from an ancestor. Read-only.
    inheritedFrom?: NullableOption<ItemReference>;
    // Details of any associated sharing invitation for this permission. Read-only.
    invitation?: NullableOption<SharingInvitation>;
    // Provides the link details of the current permission, if it's a link type permission. Read-only.
    link?: NullableOption<SharingLink>;
    // The type of permission, for example, read. See the Roles property values section for the full list of roles. Read-only.
    roles?: NullableOption<string[]>;
    // A unique token that can be used to access this shared item via the shares API. Read-only.
    shareId?: NullableOption<string>;
}

As you can see, the value for grantedToV2 is an optional SharePointIdentitySet. That does neither match the response in the documentation (https://learn.microsoft.com/en-us/graph/api/filestoragecontainer-list-permissions?view=graph-rest-beta&tabs=http#response-1) nor the response I receive.

The response I receive is of the same structure as in the documentation. What I get as value on grantedToV2 rather reminds me of Person or User - it at least does have the property userPrincipalName.

Expected behavior

The types should match both the documentation and what I receive from the GraphAPI server.

How to reproduce

Download the types and try to match the response of the API request to the defined types.

SDK Version

0.43.0-preview

Latest version known to work for scenario above?

No response

Known Workarounds

No response

Debug output
Click to expand log ```
</details>


### Configuration

_No response_

### Other information

_No response_
Linguagem predominante
PowerShell
Estrelas
129
Forks
35
Métricas de merge de PRs
Nenhum PR com merge em 30d

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de microsoftgraph/msgraph-typescript-typings

Todas as issues de microsoftgraph/msgraph-typescript-typings

Issues semelhantes

Mais issues de Backend & API Design

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.