The types for `Permission` are not as in the API.

Ouverte
#756 0 commentaires 1 réaction 0 personnes assignées Voir sur GitHub

Personne n'a encore pris cette issue.

Évaluation

Difficulté
2/5
Temps estimé
1-3 heures
Accessibilité débutants
48/100
Type d'issue
Bug
Clarté
Plutôt claire
Activité
À l'abandon
Stack technique
typescript
Domaine
api

Piste de recherche

Start by locating the beta Permission and SharePointIdentitySet type definitions, then compare grantedToV2 with the documented response and the reported Graph API response. Update the type to match the evidence and check the relevant generated or type validation tests; done means the definition accepts the reported grantedToV2 shape and remains consistent with the API documentation.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

status:waiting-for-triage type:bug
Describe the bug

The response for https://learn.microsoft.com/en-us/graph/api/filestoragecontainer-list-permissions?view=graph-rest-beta&tabs=http#response should be of type permission.

The type permission is described in the BETA package as:

export interface Permission extends Entity {
    /**
     * A format of yyyy-MM-ddTHH:mm:ssZ of DateTimeOffset indicates the expiration time of the permission. DateTime.MinValue
     * indicates there's no expiration set for this permission. Optional.
     */
    expirationDateTime?: NullableOption<string>;
    // For user type permissions, the details of the users and applications for this permission. Read-only.
    grantedTo?: NullableOption<IdentitySet>;
    // For type permissions, the details of the users to whom permission was granted. Read-only.
    grantedToIdentities?: NullableOption<IdentitySet[]>;
    // For link type permissions, the details of the users to whom permission was granted. Read-only.
    grantedToIdentitiesV2?: NullableOption<SharePointIdentitySet[]>;
    // For user type permissions, the details of the users and applications for this permission. Read-only.
    grantedToV2?: NullableOption<SharePointIdentitySet>;
    /**
     * Indicates whether the password is set for this permission. This property only appears in the response. Optional.
     * Read-only. For OneDrive Personal only.
     */
    hasPassword?: NullableOption<boolean>;
    // Provides a reference to the ancestor of the current permission, if it's inherited from an ancestor. Read-only.
    inheritedFrom?: NullableOption<ItemReference>;
    // Details of any associated sharing invitation for this permission. Read-only.
    invitation?: NullableOption<SharingInvitation>;
    // Provides the link details of the current permission, if it's a link type permission. Read-only.
    link?: NullableOption<SharingLink>;
    // The type of permission, for example, read. See the Roles property values section for the full list of roles. Read-only.
    roles?: NullableOption<string[]>;
    // A unique token that can be used to access this shared item via the shares API. Read-only.
    shareId?: NullableOption<string>;
}

As you can see, the value for grantedToV2 is an optional SharePointIdentitySet. That does neither match the response in the documentation (https://learn.microsoft.com/en-us/graph/api/filestoragecontainer-list-permissions?view=graph-rest-beta&tabs=http#response-1) nor the response I receive.

The response I receive is of the same structure as in the documentation. What I get as value on grantedToV2 rather reminds me of Person or User - it at least does have the property userPrincipalName.

Expected behavior

The types should match both the documentation and what I receive from the GraphAPI server.

How to reproduce

Download the types and try to match the response of the API request to the defined types.

SDK Version

0.43.0-preview

Latest version known to work for scenario above?

No response

Known Workarounds

No response

Debug output
Click to expand log ```
</details>


### Configuration

_No response_

### Other information

_No response_
Langage dominant
PowerShell
Étoiles
129
Forks
35
Métriques de merge des PR
Aucune PR mergée en 30 j

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de microsoftgraph/msgraph-typescript-typings

Toutes les issues de microsoftgraph/msgraph-typescript-typings

Issues similaires

Plus d'issues Backend & API Design

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.