Hacktoberfest 2026: as issues que os mantenedores marcaram para outubro, abertas e boas para iniciantes. Ver issues do Hacktoberfest

External specs do not reach user subclasses: a typestate call on a subclass receiver crashes with a sort mismatch

Fechada
  • Algo errado?
#353 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Um pull request relacionado já foi integrado.

  • #354 de @CatarinaGamboa — integrado

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
35/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
java
Domínio
compilers

Direção de pesquisa

Start from RefinedVariable (how it records superclass/interface relations) and RefinementProcessor (its first pass processes types one by one), the two components named in the Causes section. Reproduce with the Repro/AppException example on main to see the sort mismatch, then trace where the state function argument sort is chosen for a subclass receiver. Done looks like the subclass case reporting State Refinement Error: found withThrowable(e) but expected noThrowable(e) instead of crashing — but note open PR #354 is already addressing this, so coordinate before starting.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

bug

An external spec written for a class (@ExternalRefinementsFor("java.lang.Throwable")) does not reach user subclasses. A typestate call on a subclass receiver makes the verifier crash instead of reporting the violation.

Example

Spec (abridged from the Barista Throwable spec):

@ExternalRefinementsFor("java.lang.Throwable")
@StateSet({"noThrowable", "withThrowable"})
public interface ThrowableRefinements {
    @StateRefinement(to = "noThrowable(this)") void Throwable(String message);
    @StateRefinement(to = "withThrowable(this)") void Throwable(String message, Throwable cause);
    @StateRefinement(from = "noThrowable(this)", to = "withThrowable(this)") Throwable initCause(Throwable cause);
}

Client code (a real bug shape: initCause on an exception whose cause was already set throws IllegalStateException: Can't overwrite cause):

public class Repro {
    static class AppException extends RuntimeException {
        AppException(String message, Throwable cause) { super(message, cause); }
    }
    static AppException wrap(Exception underlying, Exception detail) {
        AppException e = new AppException("operation failed", underlying);
        e.initCause(detail); // throws at runtime
        return e;
    }
}

On main (be47cb68):

Error: Sort mismatch at argument #1 for function (declare-fun java.lang.Throwable.state1 (java.lang.Throwable) Int) supplied sort is Repro$AppException

The same code with Throwable e = new Throwable("operation failed", underlying); is reported as intended:

State Refinement Error: found withThrowable(e) but expected noThrowable(e)

Causes

  1. RefinedVariable records only the direct superclass and the direct interfaces, so AppException is never related to Throwable (two levels up), and the state function's argument sort does not match.
  2. A user constructor that delegates to super(...) gets the default state rather than the state the super constructor's spec gives.
  3. RefinementProcessor runs the first pass type by type, so a user class can be processed before the external spec it depends on is registered.

Found while building exercises from real Java bugs (e.g. the "Can't overwrite cause" bugs in Apache projects), where a custom exception subclass is the usual shape.

Linguagem predominante
Java
Estrelas
67
Forks
36
Merge médio
2d 4h
PRs com merge (30d)
28

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de liquid-java/liquidjava

Todas as issues de liquid-java/liquidjava

Issues semelhantes

Mais issues de Java

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.