Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

External specs do not reach user subclasses: a typestate call on a subclass receiver crashes with a sort mismatch

Cerrado
  • ¿Algo no está bien?
#353 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Ya se ha fusionado un pull request relacionado.

  • #354 de @CatarinaGamboa — fusionado

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
java
Área
compilers

Línea de trabajo

Start from RefinedVariable (how it records superclass/interface relations) and RefinementProcessor (its first pass processes types one by one), the two components named in the Causes section. Reproduce with the Repro/AppException example on main to see the sort mismatch, then trace where the state function argument sort is chosen for a subclass receiver. Done looks like the subclass case reporting State Refinement Error: found withThrowable(e) but expected noThrowable(e) instead of crashing — but note open PR #354 is already addressing this, so coordinate before starting.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug

An external spec written for a class (@ExternalRefinementsFor("java.lang.Throwable")) does not reach user subclasses. A typestate call on a subclass receiver makes the verifier crash instead of reporting the violation.

Example

Spec (abridged from the Barista Throwable spec):

@ExternalRefinementsFor("java.lang.Throwable")
@StateSet({"noThrowable", "withThrowable"})
public interface ThrowableRefinements {
    @StateRefinement(to = "noThrowable(this)") void Throwable(String message);
    @StateRefinement(to = "withThrowable(this)") void Throwable(String message, Throwable cause);
    @StateRefinement(from = "noThrowable(this)", to = "withThrowable(this)") Throwable initCause(Throwable cause);
}

Client code (a real bug shape: initCause on an exception whose cause was already set throws IllegalStateException: Can't overwrite cause):

public class Repro {
    static class AppException extends RuntimeException {
        AppException(String message, Throwable cause) { super(message, cause); }
    }
    static AppException wrap(Exception underlying, Exception detail) {
        AppException e = new AppException("operation failed", underlying);
        e.initCause(detail); // throws at runtime
        return e;
    }
}

On main (be47cb68):

Error: Sort mismatch at argument #1 for function (declare-fun java.lang.Throwable.state1 (java.lang.Throwable) Int) supplied sort is Repro$AppException

The same code with Throwable e = new Throwable("operation failed", underlying); is reported as intended:

State Refinement Error: found withThrowable(e) but expected noThrowable(e)

Causes

  1. RefinedVariable records only the direct superclass and the direct interfaces, so AppException is never related to Throwable (two levels up), and the state function's argument sort does not match.
  2. A user constructor that delegates to super(...) gets the default state rather than the state the super constructor's spec gives.
  3. RefinementProcessor runs the first pass type by type, so a user class can be processed before the external spec it depends on is registered.

Found while building exercises from real Java bugs (e.g. the "Can't overwrite cause" bugs in Apache projects), where a custom exception subclass is the usual shape.

Lenguaje dominante
Java
Estrellas
67
Forks
36
Merge medio
2 d 4 h
PR fusionados (30 d)
28

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de liquid-java/liquidjava

Todos los issues de liquid-java/liquidjava

Issues similares

Más issues de Java

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.