Import search returns nodes from channels the user can't view

Aberta
#6,419 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
1/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
python
Domínio
api, backend, security, testing

Direção de pesquisa

Read SearchContentNodeViewSet in contentcuration/search/viewsets/contentnode.py and follow the access strategy in issue #6398. Add regression coverage for list searches with and without channel_list, filtering by an inaccessible channel, and the detail route; verify visible and public channel results remain unchanged. The issue header says this is not open for contribution, so a newcomer should find a suitable issue through the linked contributing guidelines.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

DEV: backend

❌ This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues.

Overview

Import search (/api/search/search) runs over every published channel in the full-text index. It limits results to channels the user can view only when the client sends channel_list, so any logged-in user can list the nodes of published channels they haven't been given access to in Studio.

Complexity: Low
Target branch: hotfixes

Context
  • SearchContentNodeViewSet uses ContentNodeFullTextSearch.objects.all() as its queryset. The detail route uses the same queryset.
  • Reproduced: a user with no access to an unlisted published channel got its nodes, with ids, kinds and original_channel_name, from ?channel_id__in=<its id>, from ?kinds=topic, and from ?keywords=… without channel_list.
The Change
  • Search should only return nodes from channels the requesting user can view, whatever filters the client sends, following the strategy in #6398.
Acceptance Criteria
General
  • A user gets no results from a channel they can't view, with or without channel_list, including when filtering by that channel's id.
  • GET /api/search/search/<id> for a node in a channel the user can't view returns 404.
  • Results for channels the user can view, including public channels, are unchanged.
Testing
  • Regression tests cover each criterion.

AI usage

I chose which audit findings belong in #6398 and set the access pattern. Claude Code found and reproduced this gap and drafted this issue.

Linguagem predominante
Python
Estrelas
212
Forks
321
Merge médio
1d 7h
PRs com merge (30d)
14

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de learningequality/studio

Todas as issues de learningequality/studio

Issues semelhantes

Mais issues de Python

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.