Import search returns nodes from channels the user can't view

Ouverte
#6,419 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
1/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
python

Piste de recherche

Read SearchContentNodeViewSet in contentcuration/search/viewsets/contentnode.py and follow the access strategy in issue #6398. Add regression coverage for list searches with and without channel_list, filtering by an inaccessible channel, and the detail route; verify visible and public channel results remain unchanged. The issue header says this is not open for contribution, so a newcomer should find a suitable issue through the linked contributing guidelines.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

DEV: backend

❌ This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues.

Overview

Import search (/api/search/search) runs over every published channel in the full-text index. It limits results to channels the user can view only when the client sends channel_list, so any logged-in user can list the nodes of published channels they haven't been given access to in Studio.

Complexity: Low
Target branch: hotfixes

Context
  • SearchContentNodeViewSet uses ContentNodeFullTextSearch.objects.all() as its queryset. The detail route uses the same queryset.
  • Reproduced: a user with no access to an unlisted published channel got its nodes, with ids, kinds and original_channel_name, from ?channel_id__in=<its id>, from ?kinds=topic, and from ?keywords=… without channel_list.
The Change
  • Search should only return nodes from channels the requesting user can view, whatever filters the client sends, following the strategy in #6398.
Acceptance Criteria
General
  • A user gets no results from a channel they can't view, with or without channel_list, including when filtering by that channel's id.
  • GET /api/search/search/<id> for a node in a channel the user can't view returns 404.
  • Results for channels the user can view, including public channels, are unchanged.
Testing
  • Regression tests cover each criterion.

AI usage

I chose which audit findings belong in #6398 and set the access pattern. Claude Code found and reproduced this gap and drafted this issue.

Langage dominant
Python
Étoiles
212
Forks
321
Merge moyen
1 j 7 h
PR mergées (30 j)
14

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de learningequality/studio

Toutes les issues de learningequality/studio

Issues similaires

Plus d'issues Python

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.