A sync change can modify a channel other than the one it names

Aberta
#6,413 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
68/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
django, python
Domínio
api, backend, security, testing

Direção de pesquisa

Start with SyncView.handle_changes in contentcuration/contentcuration/viewsets/sync/endpoint.py, then trace the contentnode create, update, and move handlers that use parent or target. Add tests for changes naming a different channel and run the relevant sync endpoint tests. Done means those mismatched changes are rejected without creating nodes or change records, while valid same-channel changes still work.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

DEV: backend

Overview

The sync endpoint checks that the user can edit the channel_id a change names, and records the change under that channel. Nothing checks that the parent or target of a contentnode create, update or move is in that channel. A user who edits two channels can send a change naming channel A that creates a node in channel B, and channel B records no change for it, so its unpublished-changes tracking misses the edit.

Complexity: Medium
Target branch: hotfixes

Context
  • SyncView.handle_changes sorts changes by their channel_id and creates the Change rows with it. The contentnode create, update and move handlers then place the node under whatever parent or target the change gives.
  • Reproduced: an editor of channels A and B sent a contentnode create change with channel_id A and parent set to B's root node. The node was created in B, the Change row was recorded under A, and B had no Change rows.
The Change
  • A contentnode create, update or move change should be rejected when its parent or target isn't in the channel the change names.
Acceptance Criteria
General
  • The reproduced change in Context is rejected with an error, and nothing is created in either channel.
  • Changes whose objects are in the named channel are applied as before.
Testing
  • Tests cover create, update and move changes whose parent or target is in a different channel from the one the change names.

AI usage

I scoped the audit. Claude Code found and reproduced this failure and drafted this issue.

Linguagem predominante
Python
Estrelas
212
Forks
321
Merge médio
1d 7h
PRs com merge (30d)
14

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de learningequality/studio

Todas as issues de learningequality/studio

Issues semelhantes

Mais issues de Python

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.