A sync change can modify a channel other than the one it names

Ouverte
#6,413 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
68/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
django, python

Piste de recherche

Start with SyncView.handle_changes in contentcuration/contentcuration/viewsets/sync/endpoint.py, then trace the contentnode create, update, and move handlers that use parent or target. Add tests for changes naming a different channel and run the relevant sync endpoint tests. Done means those mismatched changes are rejected without creating nodes or change records, while valid same-channel changes still work.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

DEV: backend

Overview

The sync endpoint checks that the user can edit the channel_id a change names, and records the change under that channel. Nothing checks that the parent or target of a contentnode create, update or move is in that channel. A user who edits two channels can send a change naming channel A that creates a node in channel B, and channel B records no change for it, so its unpublished-changes tracking misses the edit.

Complexity: Medium
Target branch: hotfixes

Context
  • SyncView.handle_changes sorts changes by their channel_id and creates the Change rows with it. The contentnode create, update and move handlers then place the node under whatever parent or target the change gives.
  • Reproduced: an editor of channels A and B sent a contentnode create change with channel_id A and parent set to B's root node. The node was created in B, the Change row was recorded under A, and B had no Change rows.
The Change
  • A contentnode create, update or move change should be rejected when its parent or target isn't in the channel the change names.
Acceptance Criteria
General
  • The reproduced change in Context is rejected with an error, and nothing is created in either channel.
  • Changes whose objects are in the named channel are applied as before.
Testing
  • Tests cover create, update and move changes whose parent or target is in a different channel from the one the change names.

AI usage

I scoped the audit. Claude Code found and reproduced this failure and drafted this issue.

Langage dominant
Python
Étoiles
212
Forks
321
Merge moyen
1 j 7 h
PR mergées (30 j)
14

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de learningequality/studio

Toutes les issues de learningequality/studio

Issues similaires

Plus d'issues Python

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.