Feedback events take `user` from the request and allow updates to other users' events

Aberta
#6,401 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
56/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
django, python

Direção de pesquisa

Start with contentcuration/contentcuration/viewsets/feedback.py, especially the serializers and three viewsets identified in the issue, then read the strategy in issue #6398. Add regression tests for spoofed users and updates to another user's recommendation, interaction, and flag events. Done means the ownership and response-code acceptance criteria pass while users can still create and update their own events.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

DEV: backend

Overview

The feedback event endpoints take user from the request body, and their update routes accept any event. Any logged-in user can record recommendation events as another user and change another user's recommendation events by id. The flagged-content endpoint has the same shape for users with the test_dev_feature flag.

Complexity: Low
Target branch: hotfixes

Context
  • BaseFeedbackEventSerializer marks user read-only, but FlagFeedbackEventSerializer and RecommendationsEventSerializer declare their own Meta, which drops it. Nothing sets user from the request.
  • The three viewsets use .objects.all() with no ownership filter.
  • Reproduced:
    • POST /api/events/recommendations with another user's id in user returns 201, and the event is recorded as theirs.
    • PATCH /api/events/recommendations/<another user's event id> returns 200 and changes the event.
The Change
  • user should be read-only on every feedback event serializer and set from request.user, following the strategy in #6398.
  • Update routes should only find the requester's own events. Interaction events belong to the requester through their recommendation_event_id.
Acceptance Criteria
General
  • Creating a recommendation or flag event with another user's id in user records the event as the requester's.
  • PUT and PATCH on another user's recommendation or interaction event return 404. On another user's flag event they return 404 for users with the test_dev_feature flag, and 403 as now for users without it.
  • Users can still create and update their own events.
Testing
  • Regression tests cover spoofed user on create and updates to another user's event, for each event type.

AI usage

I chose which audit findings belong in #6398 and set the access pattern. Claude Code found and reproduced this gap and drafted this issue.

Linguagem predominante
Python
Estrelas
212
Forks
321
Merge médio
1d 7h
PRs com merge (30d)
14

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de learningequality/studio

Todas as issues de learningequality/studio

Issues semelhantes

Mais issues de Python

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.