Feedback events take `user` from the request and allow updates to other users' events

Abierto
#6,401 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
56/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
django, python

Línea de trabajo

Start with contentcuration/contentcuration/viewsets/feedback.py, especially the serializers and three viewsets identified in the issue, then read the strategy in issue #6398. Add regression tests for spoofed users and updates to another user's recommendation, interaction, and flag events. Done means the ownership and response-code acceptance criteria pass while users can still create and update their own events.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

DEV: backend

Overview

The feedback event endpoints take user from the request body, and their update routes accept any event. Any logged-in user can record recommendation events as another user and change another user's recommendation events by id. The flagged-content endpoint has the same shape for users with the test_dev_feature flag.

Complexity: Low
Target branch: hotfixes

Context
  • BaseFeedbackEventSerializer marks user read-only, but FlagFeedbackEventSerializer and RecommendationsEventSerializer declare their own Meta, which drops it. Nothing sets user from the request.
  • The three viewsets use .objects.all() with no ownership filter.
  • Reproduced:
    • POST /api/events/recommendations with another user's id in user returns 201, and the event is recorded as theirs.
    • PATCH /api/events/recommendations/<another user's event id> returns 200 and changes the event.
The Change
  • user should be read-only on every feedback event serializer and set from request.user, following the strategy in #6398.
  • Update routes should only find the requester's own events. Interaction events belong to the requester through their recommendation_event_id.
Acceptance Criteria
General
  • Creating a recommendation or flag event with another user's id in user records the event as the requester's.
  • PUT and PATCH on another user's recommendation or interaction event return 404. On another user's flag event they return 404 for users with the test_dev_feature flag, and 403 as now for users without it.
  • Users can still create and update their own events.
Testing
  • Regression tests cover spoofed user on create and updates to another user's event, for each event type.

AI usage

I chose which audit findings belong in #6398 and set the access pattern. Claude Code found and reproduced this gap and drafted this issue.

Lenguaje dominante
Python
Estrellas
212
Forks
321
Merge medio
1 d 7 h
PR fusionados (30 d)
14

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de learningequality/studio

Todos los issues de learningequality/studio

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.