Feedback events take `user` from the request and allow updates to other users' events
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 56/100
- Tipo de issue
- Error
- Claridad
- Bien especificado
- Estado de actividad
- Activo
Línea de trabajo
Start with contentcuration/contentcuration/viewsets/feedback.py, especially the serializers and three viewsets identified in the issue, then read the strategy in issue #6398. Add regression tests for spoofed users and updates to another user's recommendation, interaction, and flag events. Done means the ownership and response-code acceptance criteria pass while users can still create and update their own events.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Overview
The feedback event endpoints take user from the request body, and their update routes accept any event. Any logged-in user can record recommendation events as another user and change another user's recommendation events by id. The flagged-content endpoint has the same shape for users with the test_dev_feature flag.
Complexity: Low
Target branch: hotfixes
Context
BaseFeedbackEventSerializermarksuserread-only, butFlagFeedbackEventSerializerandRecommendationsEventSerializerdeclare their ownMeta, which drops it. Nothing setsuserfrom the request.- The three viewsets use
.objects.all()with no ownership filter. - Reproduced:
POST /api/events/recommendationswith another user's id inuserreturns 201, and the event is recorded as theirs.PATCH /api/events/recommendations/<another user's event id>returns 200 and changes the event.
The Change
usershould be read-only on every feedback event serializer and set fromrequest.user, following the strategy in #6398.- Update routes should only find the requester's own events. Interaction events belong to the requester through their
recommendation_event_id.
Acceptance Criteria
General
- Creating a recommendation or flag event with another user's id in
userrecords the event as the requester's. -
PUTandPATCHon another user's recommendation or interaction event return 404. On another user's flag event they return 404 for users with thetest_dev_featureflag, and 403 as now for users without it. - Users can still create and update their own events.
Testing
- Regression tests cover spoofed
useron create and updates to another user's event, for each event type.
AI usage
I chose which audit findings belong in #6398 and set the access pattern. Claude Code found and reproduced this gap and drafted this issue.
- Lenguaje dominante
- Python
- Estrellas
- 212
- Forks
- 321
- Merge medio
- 1 d 7 h
- PR fusionados (30 d)
- 14
Preparar el entorno
- Incluye un Dockerfile o un archivo de Docker Compose
- Sin plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de learningequality/studio
-
Community library status changes don't update `date_updated`Posiblemente ocupada @ArpitaSamanta10 la tomó hoy. Abiertocommunity-contribution-in-progress DEV: backend good first issue help wanted
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
learningequality/studio#6414 · 8 comentarios · 1 asignado ·
Los mantenedores suelen responder en 1 día
-
DEV: backend
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
learningequality/studio#6410 ·
Los mantenedores suelen responder en 1 día
-
DEV: backend
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
learningequality/studio#6409 ·
Los mantenedores suelen responder en 1 día
-
DEV: backend
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
learningequality/studio#6407 ·
Los mantenedores suelen responder en 1 día
-
Stripe webhook accepts events when no webhook secret is configuredPosiblemente ocupada @adibmbrk la tomó hoy. Abiertocommunity-contribution-in-progress DEV: backend good first issue help wanted
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
learningequality/studio#6404 · 3 comentarios · 1 asignado ·
Los mantenedores suelen responder en 1 día
Todos los issues de learningequality/studio
Issues similares
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 77/100
canonical/paas-charm#407 · 1 comentario ·
Los mantenedores suelen responder en 5 días
-
bug
Dificultad 1/5 Menos de una hora Aptitud para principiantes 90/100
FAIRmat-NFDI/pynxtools-spm#136 ·
Los mantenedores suelen responder en 1 día
-
enhancement tooling
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
Los mantenedores suelen responder en 1 día
-
`read_nexus` entry point points to a function that no longer existsPosiblemente ocupada @RubelMozumder la tomó hoy. Abiertoannotator bug
Dificultad 1/5 Menos de una hora Aptitud para principiantes 88/100
FAIRmat-NFDI/pynxtools#876 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
[Bug]: HTTP 499 (Client Closed Request) is classified as a non-retryable format_error, so a mid-flight abort fails the turn over instead of retryingPosiblemente ocupada @yipinghuang1991 la tomó hoy. Abiertocomp/agent P2 type/bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
NousResearch/hermes-agent#156837 ·
Los mantenedores suelen responder en 1 día