ob status does not report a route domain that has no certificate

Aberta
  • Algo errado?
#237 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
55/100
Tipo de issue
Bug
Clareza
Razoavelmente clara
Status de atividade
Ativa
Stack de tecnologia
go
Domínio
cli, devops

Direção de pesquisa

Start from the ob status certificate checks and proxy.CertExpiries, which the issue says currently reads only domain.main; trace how applied resolvers, ACME stores, and terminating route domains reach that code. Check route discovery output under /etc/traefik/dynamic if the existing route data is insufficient. Done when status reports missing or renewal-floor certificates for route domains, counts SAN and wildcard coverage, and avoids immediate divergence while issuance is pending.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

enhancement

What happens

ob status reports a healthy proxy when a terminating route's domain has no certificate from the resolver that should issue it. If the configured resolver never obtains a certificate for a domain (for example, the HTTP-01 challenge is blocked or the DNS-01 token is wrong), Traefik serves its default self-signed certificate for that domain. Status does not mention the domain at all.

Status only judges certificates that exist in the ACME stores. A domain with no renewable certificate does not appear there, so it raises no issue and does not set Diverged.

Before #236 this case was sometimes caught by accident. If a leftover resolver key still held an old certificate for the domain, that certificate was eventually flagged as overdue. Since #236, a leftover certificate is marked orphaned and never flagged, so nothing reports the missing one.

Expected

For each domain that a terminating route serves, status checks that a resolver in the applied static configuration holds a certificate for it in the store it writes, and that the certificate is outside the renewal floor. A route domain with no such certificate is reported as an issue, and status diverges. Wildcard routes are covered by a matching wildcard certificate from the wildcard resolver.

Notes

  • The route domains come from the application's routes, which status already knows, or from the discovery controller's output in /etc/traefik/dynamic.
  • A certificate's SANs should count as well as domain.main. proxy.CertExpiries currently extracts only domain.main, so a domain covered only through a SAN would be reported as missing.
  • A route whose certificate is still being issued right after its first deploy should not report divergence immediately. A short grace period, or reporting it as pending, avoids a false alarm.

Reproduce

  1. Deploy an application with a terminating route for a domain whose ACME challenge cannot succeed, for example a domain whose DNS does not point at the host.
  2. Wait for Traefik's issuance attempt to fail. The domain then serves Traefik's default certificate.
  3. Run ob status. It reports the proxy as in sync and exits zero.
Linguagem predominante
Go
Estrelas
4
Forks
0
Merge médio
36min
PRs com merge (30d)
13

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de labstack/onebox

Todas as issues de labstack/onebox

Issues semelhantes

Mais issues de Go

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.