ob status does not report a route domain that has no certificate

Aperta
  • Qualcosa non va?
#237 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
55/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
go
Ambito
cli, devops

Direzione di ricerca

Start from the ob status certificate checks and proxy.CertExpiries, which the issue says currently reads only domain.main; trace how applied resolvers, ACME stores, and terminating route domains reach that code. Check route discovery output under /etc/traefik/dynamic if the existing route data is insufficient. Done when status reports missing or renewal-floor certificates for route domains, counts SAN and wildcard coverage, and avoids immediate divergence while issuance is pending.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement

What happens

ob status reports a healthy proxy when a terminating route's domain has no certificate from the resolver that should issue it. If the configured resolver never obtains a certificate for a domain (for example, the HTTP-01 challenge is blocked or the DNS-01 token is wrong), Traefik serves its default self-signed certificate for that domain. Status does not mention the domain at all.

Status only judges certificates that exist in the ACME stores. A domain with no renewable certificate does not appear there, so it raises no issue and does not set Diverged.

Before #236 this case was sometimes caught by accident. If a leftover resolver key still held an old certificate for the domain, that certificate was eventually flagged as overdue. Since #236, a leftover certificate is marked orphaned and never flagged, so nothing reports the missing one.

Expected

For each domain that a terminating route serves, status checks that a resolver in the applied static configuration holds a certificate for it in the store it writes, and that the certificate is outside the renewal floor. A route domain with no such certificate is reported as an issue, and status diverges. Wildcard routes are covered by a matching wildcard certificate from the wildcard resolver.

Notes

  • The route domains come from the application's routes, which status already knows, or from the discovery controller's output in /etc/traefik/dynamic.
  • A certificate's SANs should count as well as domain.main. proxy.CertExpiries currently extracts only domain.main, so a domain covered only through a SAN would be reported as missing.
  • A route whose certificate is still being issued right after its first deploy should not report divergence immediately. A short grace period, or reporting it as pending, avoids a false alarm.

Reproduce

  1. Deploy an application with a terminating route for a domain whose ACME challenge cannot succeed, for example a domain whose DNS does not point at the host.
  2. Wait for Traefik's issuance attempt to fail. The domain then serves Traefik's default certificate.
  3. Run ob status. It reports the proxy as in sync and exits zero.
Lingua principale
Go
Stelle
4
Fork
0
Merge medio
36m
PR unite (30g)
13

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di labstack/onebox

Tutte le issue di labstack/onebox

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.