forms that intentionally reuse a key with mutually exclusive conditionals

Aberta
#651 3 comentários 0 reações 0 responsáveis Ver no GitHub

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
64/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
react, typescript
Domínio
frontend

Direção de pesquisa

Reproduce the issue with the two mutually exclusive name fields in the report, using a blank submission. Start by tracing the visibility check and clearComponentOnHide() behavior described in the issue, then follow how deleteValue() affects the shared key. Done means entering a valid name no longer clears the shared value or triggers the required-field validation message.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Describe the bug
I was using Formio/React 5.3.0 but when I upgraded to 6.2.1 I found that duplicate key reuse for mutually exclusive conditions always throws validation error.

In @formio/react 5.3.0 (formiojs 4), clearOnHide only runs when visibility changes:

if (this.visible !== visible) {
  this.visible = visible; // setter may clear
}

Once the edit field is already hidden, later condition checks leave data.name alone, so the create field keeps working.

In @formio/react 6.2.1 (@formio/js 5), every condition check clears a hidden field:

if (this.visible !== visible) {
  this.visible = visible;
}
this.clearComponentOnHide(); // always, while hidden

So on create, the hidden edit name repeatedly does deleteValue() on the shared data.name. The create field then fails required, and customMessage makes it look like the pattern error.

below is my two components with the same name but conditional:

{
    "key": "name",
    "type": "textfield",
    "input": true,
    "label": "Name",
    "disabled": true,
    "validate": {
        "pattern": "^[a-zA-Z0-9\\s]*$",
        "required": true,
        "maxLength": 80,
        "customMessage": "Invalid name; must contain only letters, numbers or spaces "
    },
    "autofocus": true,
    "tableView": true,
    "spellcheck": false,
    "showCharCount": true,
    "customConditional": "show = data.submissionUuid.length > 0",
    "hideOnChildrenHidden": false
},
{
    "key": "name",
    "type": "textfield",
    "input": true,
    "label": "Name",
    "validate": {
        "pattern": "^[a-zA-Z0-9\\s]*$",
        "required": true,
        "maxLength": 80,
        "customMessage": "Invalid name; must contain only letters, numbers or spaces "
    },
    "autofocus": true,
    "tableView": true,
    "spellcheck": false,
    "showCharCount": true,
    "customConditional": "show = data.submissionUuid.length === 0",
    "hideOnChildrenHidden": false
}

To Reproduce
Steps to reproduce the behavior:

  1. create a form with customConditionals has shown above
  2. use that form with a Form component with no submission data or a blank object.
  3. on entry of the name you will always get the customMessage.

Expected behavior
I would expect it not to deleteValue() on the shared data.name so we will not get a custom validation message if the text entered is valid.

Screenshots
here is a screen shot of what i with mutually exclusive conditionals

Image
Linguagem predominante
TypeScript
Estrelas
371
Forks
309
Métricas de merge de PRs
Nenhum PR com merge em 30d

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de formio/react

Todas as issues de formio/react

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.