forms that intentionally reuse a key with mutually exclusive conditionals

Abierto
#651 3 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
64/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
react, typescript
Área
frontend

Línea de trabajo

Reproduce the issue with the two mutually exclusive name fields in the report, using a blank submission. Start by tracing the visibility check and clearComponentOnHide() behavior described in the issue, then follow how deleteValue() affects the shared key. Done means entering a valid name no longer clears the shared value or triggers the required-field validation message.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Describe the bug
I was using Formio/React 5.3.0 but when I upgraded to 6.2.1 I found that duplicate key reuse for mutually exclusive conditions always throws validation error.

In @formio/react 5.3.0 (formiojs 4), clearOnHide only runs when visibility changes:

if (this.visible !== visible) {
  this.visible = visible; // setter may clear
}

Once the edit field is already hidden, later condition checks leave data.name alone, so the create field keeps working.

In @formio/react 6.2.1 (@formio/js 5), every condition check clears a hidden field:

if (this.visible !== visible) {
  this.visible = visible;
}
this.clearComponentOnHide(); // always, while hidden

So on create, the hidden edit name repeatedly does deleteValue() on the shared data.name. The create field then fails required, and customMessage makes it look like the pattern error.

below is my two components with the same name but conditional:

{
    "key": "name",
    "type": "textfield",
    "input": true,
    "label": "Name",
    "disabled": true,
    "validate": {
        "pattern": "^[a-zA-Z0-9\\s]*$",
        "required": true,
        "maxLength": 80,
        "customMessage": "Invalid name; must contain only letters, numbers or spaces "
    },
    "autofocus": true,
    "tableView": true,
    "spellcheck": false,
    "showCharCount": true,
    "customConditional": "show = data.submissionUuid.length > 0",
    "hideOnChildrenHidden": false
},
{
    "key": "name",
    "type": "textfield",
    "input": true,
    "label": "Name",
    "validate": {
        "pattern": "^[a-zA-Z0-9\\s]*$",
        "required": true,
        "maxLength": 80,
        "customMessage": "Invalid name; must contain only letters, numbers or spaces "
    },
    "autofocus": true,
    "tableView": true,
    "spellcheck": false,
    "showCharCount": true,
    "customConditional": "show = data.submissionUuid.length === 0",
    "hideOnChildrenHidden": false
}

To Reproduce
Steps to reproduce the behavior:

  1. create a form with customConditionals has shown above
  2. use that form with a Form component with no submission data or a blank object.
  3. on entry of the name you will always get the customMessage.

Expected behavior
I would expect it not to deleteValue() on the shared data.name so we will not get a custom validation message if the text entered is valid.

Screenshots
here is a screen shot of what i with mutually exclusive conditionals

Image
Lenguaje dominante
TypeScript
Estrellas
371
Forks
309
Métricas de merge de PR
Sin PR fusionados en 30 d

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de formio/react

Todos los issues de formio/react

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.