Add Incremental Diff File Fetching to the Diff Cache

Aberta
#181 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
72/100
Tipo de issue
Funcionalidade
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
typescript

Direção de pesquisa

Start with packages/core/src/review/diff-cache.ts and trace the full-diff path to find its file filtering and cache behavior. Check the ReviewGitProvider.getCompareDiff interface and the existing diff-cache tests, then add mocked-provider coverage for the new function. Done means it returns files changed between the supplied SHAs, applies the same reviewable-file filter, and follows the existing cache semantics.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

enhancement good first issue

Goal

Add getIncrementalDiffFiles to packages/core/src/review/diff-cache.ts that fetches the commit-to-commit diff instead of the full PR diff.

Background

ReviewGitProvider already exposes getCompareDiff(owner, repo, base, head), but it is only used for the dashboard diff viewer. This sub-issue wires that capability into the review diff path for incremental reviews.

This sub-issue is part of the parent issue: incremental reviews on synchronize events.

What to Build

  • Add getIncrementalDiffFiles to diff-cache.ts that calls github.getCompareDiff(owner, repo, previousCommitSha, newHeadSha)
  • Apply the same reviewable-file filtering used by the full-diff path
  • Respect the existing diff cache semantics so the incremental diff is cached the same way
  • Include PR-level context handling notes: the caller still needs PR title, description, and suppressed findings (handled in the wiring sub-issue)

Done When

  • getIncrementalDiffFiles returns only files changed between the two SHAs
  • Reviewable-file filtering matches the full-diff path behavior
  • Caching behaves consistently with the existing diff cache
  • Unit tests cover the new function with a mocked git provider
  • npm run typecheck, npm test, and npm run lint all pass
Linguagem predominante
TypeScript
Estrelas
125
Forks
23
Merge médio
2d 13h
PRs com merge (30d)
12

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de devarshishimpi/codra

Todas as issues de devarshishimpi/codra

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.