Add Incremental Diff File Fetching to the Diff Cache

Abierto
#181 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
72/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
typescript

Línea de trabajo

Start with packages/core/src/review/diff-cache.ts and trace the full-diff path to find its file filtering and cache behavior. Check the ReviewGitProvider.getCompareDiff interface and the existing diff-cache tests, then add mocked-provider coverage for the new function. Done means it returns files changed between the supplied SHAs, applies the same reviewable-file filter, and follows the existing cache semantics.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement good first issue

Goal

Add getIncrementalDiffFiles to packages/core/src/review/diff-cache.ts that fetches the commit-to-commit diff instead of the full PR diff.

Background

ReviewGitProvider already exposes getCompareDiff(owner, repo, base, head), but it is only used for the dashboard diff viewer. This sub-issue wires that capability into the review diff path for incremental reviews.

This sub-issue is part of the parent issue: incremental reviews on synchronize events.

What to Build

  • Add getIncrementalDiffFiles to diff-cache.ts that calls github.getCompareDiff(owner, repo, previousCommitSha, newHeadSha)
  • Apply the same reviewable-file filtering used by the full-diff path
  • Respect the existing diff cache semantics so the incremental diff is cached the same way
  • Include PR-level context handling notes: the caller still needs PR title, description, and suppressed findings (handled in the wiring sub-issue)

Done When

  • getIncrementalDiffFiles returns only files changed between the two SHAs
  • Reviewable-file filtering matches the full-diff path behavior
  • Caching behaves consistently with the existing diff cache
  • Unit tests cover the new function with a mocked git provider
  • npm run typecheck, npm test, and npm run lint all pass
Lenguaje dominante
TypeScript
Estrellas
125
Forks
23
Merge medio
2 d 13 h
PR fusionados (30 d)
12

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de devarshishimpi/codra

Todos los issues de devarshishimpi/codra

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.