Add Incremental Reviews on Synchronize Events

Aberta
#172 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
5/5
Tempo estimado
Mais de uma semana
Facilidade para iniciantes
35/100
Tipo de issue
Funcionalidade
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
github, typescript
Domínio
backend, devtools

Direção de pesquisa

Start with packages/core/src/review/diff-cache.ts and trace how review jobs obtain diffs and how ReviewGitProvider.getCompareDiff is used. Then inspect the synchronize job flow, review settings, dashboard job details, and related tests named by the work breakdown. Done means incremental reviews use the commit delta with a full diff fallback, preserve existing full-review behavior, show the reviewed commit range, and cover the listed paths across supported backends.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

enhancement good first issue

Summary

When a developer pushes a new commit to an open PR (synchronize event), Codra re-fetches the entire base-to-head PR diff and re-reviews every changed file from scratch. On a large PR with many files, this burns the full token budget and several minutes of wall-clock time, even if only a single file changed in the new commit.

This parent issue tracks adding optional incremental reviews. See sub-issues for each implementation step.

Work Breakdown

  • Sub-issue: Add review.incremental schema setting and document it
  • Sub-issue: Store and resolve previousCommitSha for synchronize jobs
  • Sub-issue: Add getIncrementalDiffFiles to diff-cache.ts
  • Sub-issue: Wire incremental path in the review phase and add fallback logic
  • Sub-issue: Show reviewed commit range in dashboard job details

Current Behavior

In packages/core/src/review/diff-cache.ts:

rawDiff = await github.getPullRequestDiff(job.owner, job.repo, job.prNumber);

This always fetches the full PR diff (base to head), regardless of how many files changed in the latest push. The existing getCompareDiff method on ReviewGitProvider already supports commit-to-commit comparison but is only used for the dashboard diff viewer, never for review execution.

Proposed Behavior

When review.incremental: true is set:

  1. On synchronize, resolve previousCommitSha from the most recently completed job on the same PR
  2. Fetch github.getCompareDiff(owner, repo, previousCommitSha, newHeadSha) to get only the commit-delta diff
  3. Run the LLM review only on files in the incremental diff
  4. Retain PR-level context (title, description, existing finding fingerprints) for the summary
  5. Use the existing loadSuppressedFingerprints mechanism to avoid re-posting identical findings
  6. Fall back to full PR diff if previousCommitSha is not available

Done When

  • review.incremental: true triggers commit-delta diff fetching on synchronize events
  • Only files changed between the previous and new commit are sent to LLM review
  • Falls back to full PR diff gracefully when no previous commit SHA is available
  • Existing auto-triggered and mention-triggered full reviews continue to work unchanged
  • Job details in the dashboard show the reviewed commit range for incremental jobs
  • Tests cover incremental path, full-diff fallback, and superseded-job resumption
  • Any backend changes work in both Cloudflare Workers and Node/Docker
  • npm run typecheck, npm test, and npm run lint all pass
Linguagem predominante
TypeScript
Estrelas
125
Forks
23
Merge médio
2d 13h
PRs com merge (30d)
12

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de devarshishimpi/codra

Todas as issues de devarshishimpi/codra

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.