Add Incremental Reviews on Synchronize Events
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 35/100
- Tipo de issue
- Nueva funcionalidad
- Claridad
- Bien especificado
- Estado de actividad
- Activo
- Stack tecnológico
- github, typescript
Línea de trabajo
Start with packages/core/src/review/diff-cache.ts and trace how review jobs obtain diffs and how ReviewGitProvider.getCompareDiff is used. Then inspect the synchronize job flow, review settings, dashboard job details, and related tests named by the work breakdown. Done means incremental reviews use the commit delta with a full diff fallback, preserve existing full-review behavior, show the reviewed commit range, and cover the listed paths across supported backends.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Summary
When a developer pushes a new commit to an open PR (synchronize event), Codra re-fetches the entire base-to-head PR diff and re-reviews every changed file from scratch. On a large PR with many files, this burns the full token budget and several minutes of wall-clock time, even if only a single file changed in the new commit.
This parent issue tracks adding optional incremental reviews. See sub-issues for each implementation step.
Work Breakdown
- Sub-issue: Add
review.incrementalschema setting and document it - Sub-issue: Store and resolve
previousCommitShafor synchronize jobs - Sub-issue: Add
getIncrementalDiffFilesto diff-cache.ts - Sub-issue: Wire incremental path in the review phase and add fallback logic
- Sub-issue: Show reviewed commit range in dashboard job details
Current Behavior
In packages/core/src/review/diff-cache.ts:
rawDiff = await github.getPullRequestDiff(job.owner, job.repo, job.prNumber);
This always fetches the full PR diff (base to head), regardless of how many files changed in the latest push. The existing getCompareDiff method on ReviewGitProvider already supports commit-to-commit comparison but is only used for the dashboard diff viewer, never for review execution.
Proposed Behavior
When review.incremental: true is set:
- On
synchronize, resolvepreviousCommitShafrom the most recently completed job on the same PR - Fetch
github.getCompareDiff(owner, repo, previousCommitSha, newHeadSha)to get only the commit-delta diff - Run the LLM review only on files in the incremental diff
- Retain PR-level context (title, description, existing finding fingerprints) for the summary
- Use the existing
loadSuppressedFingerprintsmechanism to avoid re-posting identical findings - Fall back to full PR diff if
previousCommitShais not available
Done When
-
review.incremental: truetriggers commit-delta diff fetching onsynchronizeevents - Only files changed between the previous and new commit are sent to LLM review
- Falls back to full PR diff gracefully when no previous commit SHA is available
- Existing auto-triggered and mention-triggered full reviews continue to work unchanged
- Job details in the dashboard show the reviewed commit range for incremental jobs
- Tests cover incremental path, full-diff fallback, and superseded-job resumption
- Any backend changes work in both Cloudflare Workers and Node/Docker
-
npm run typecheck,npm test, andnpm run lintall pass
- Lenguaje dominante
- TypeScript
- Estrellas
- 125
- Forks
- 23
- Merge medio
- 2 d 13 h
- PR fusionados (30 d)
- 12
Preparar el entorno
- Incluye un Dockerfile o un archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de devarshishimpi/codra
-
bug good first issue
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
devarshishimpi/codra#178 ·
Los mantenedores suelen responder en 1 día
-
bug good first issue
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
devarshishimpi/codra#176 ·
Los mantenedores suelen responder en 1 día
-
enhancement good first issue
Dificultad 4/5 3-5 días Aptitud para principiantes 48/100
devarshishimpi/codra#186 ·
Los mantenedores suelen responder en 1 día
-
enhancement good first issue
Dificultad 4/5 3-5 días Aptitud para principiantes 55/100
devarshishimpi/codra#185 ·
Los mantenedores suelen responder en 1 día
-
enhancement good first issue
Dificultad 4/5 3-5 días Aptitud para principiantes 58/100
devarshishimpi/codra#184 ·
Los mantenedores suelen responder en 1 día
Todos los issues de devarshishimpi/codra
Issues similares
-
Dificultad 1/5 1-3 horas Aptitud para principiantes 83/100
gofish-graphics/gofish-graphics#1384 ·
Los mantenedores suelen responder en 1 día
-
adapter bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 83/100
Olanetsoft/agent-lookout#353 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
vicharanashala/vibe#1542 ·
Los mantenedores suelen responder en 1 día
-
bug chore P2 size:XS
Dificultad 2/5 1-3 horas Aptitud para principiantes 77/100
josephfung/curia#2666 ·
Los mantenedores suelen responder en 1 día
-
area: batch
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
inabagumi/shinju-date#7294 ·
Los mantenedores suelen responder en 1 día