[coverage] Conformance findings: AUTH-015,AUTH-016
Ninguém assumiu esta issue ainda.
Avaliação
- Dificuldade
- 4/5
- Tempo estimado
- 3-5 dias
- Facilidade para iniciantes
- 58/100
- Tipo de issue
- Bug
- Clareza
- Razoavelmente clara
- Status de atividade
- Ativa
- Stack de tecnologia
- python
- Domínio
- authentication, backend, security
Direção de pesquisa
Comece lendo SSLOptions.create_ssl_context(), backend/kernel/client.py::_kernel_tls_kwargs e _read_pem_bytes; depois, inspecione UnifiedHttpClient._setup_pool_managers. Use os testes xfail nomeados na PR de cobertura como verificações de aceitação. Considera-se concluído quando AUTH-015 rejeita configurações mTLS incompletas antes de se conectar e AUTH-016 informa a entrada de certificado ou chave privada afetada quando há arquivos ausentes ou vazios.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
Summary
Surfaced by the multi-language coverage fan-out while conformance-testing these SPEC-IDs against databricks/databricks-sql-python. Each finding is committed as an expected-failure (xfail) test in the coverage PR — the test asserts the CORRECT (post-fix) behavior and stays red until THIS driver (databricks/databricks-sql-python) is fixed, then flips green as a tripwire.
Findings
- AUTH-015 [thrift, sea]: a lone
_tls_client_cert_key_file(private key without client cert) is silently dropped and the connection proceeds over one-way TLS with no client identity instead of failing fast; both SSLOptions.create_ssl_context() and _kernel_tls_kwargs gate solely onif cert_file:, so the kernel's own cert/key pairing check is never reached- failing test:
test_mutual_tls_requires_client_certificate_alongside_private_key(see the coverage PR diff undertests/)
- failing test:
- AUTH-016 [thrift]: an unreadable or empty mTLS client-identity file fails with a raw stdlib error that does not identify which input failed (bare FileNotFoundError for a missing path,
SSLError: [SSL] PEM libfor an empty file) because UnifiedHttpClient._setup_pool_managers calls ssl_context.load_cert_chain with no try/except- failing test:
test_mutual_tls_rejects_unreadable_or_empty_client_identity_file(see the coverage PR diff undertests/)
- failing test:
- AUTH-016 [sea]: an unreadable or empty mTLS client-identity file fails with a raw stdlib error that does not identify which input failed; the kernel path's own diagnostics in _read_pem_bytes (which name tls_client_cert_file / tls_client_cert_key_file and the path) never surface because the unconditional UnifiedHttpClient build throws load_cert_chain's raw error first
- failing test:
test_mutual_tls_rejects_unreadable_or_empty_client_identity_file(see the coverage PR diff undertests/)
- failing test:
- AUTH-015: a lone
_tls_client_cert_key_file(private key without client cert) is silently dropped and the connection proceeds over one-way TLS with no client identity instead of failing fast; bothSSLOptions.create_ssl_context()andbackend/kernel/client.py::_kernel_tls_kwargsgate solely onif cert_file:, so the kernel's own "client_key_pem is set without client_cert_pem" pairing check is never reached - AUTH-016: an unreadable or empty mTLS client-identity file fails with a raw stdlib error that does not identify which input failed (
FileNotFoundError: [Errno 2] No such file or directoryfor a missing path,SSLError: [SSL] PEM libfor an empty file) becauseUnifiedHttpClient._setup_pool_managerscallsssl_context.load_cert_chain(cert, key, password)with no try/except; the kernel path's own diagnostics in_read_pem_bytes(which do nametls_client_cert_file/tls_client_cert_key_fileand the path) never surface since the unconditional UnifiedHttpClient build throws first
Reproduce & Expected
AUTH-015 — Verifies that enabling mutual TLS with an incomplete or contradictory configuration is rejected at connect time, before any connection is established — the driver fails fast rather than silently fall…
Expected (per the shared spec):
- full assertion contract:
result:
- label: missing_both
error:
contains:
- clientcert
- client cert
- certificate
- clientprivatekey
- private key
- required
- missing
- label: missing_both
connection_not_established: true
- label: missing_key
error:
contains:
- clientprivatekey
- private key
- required
- missing
- label: missing_key
connection_not_established: true
- label: missing_cert
error:
contains:
- clientcert
- client cert
- certificate
- required
- missing
- label: missing_cert
connection_not_established: true
- label: plaintext
error:
contains:
- ssl
- tls
- https
- requires
- label: plaintext
connection_not_established: true
- label: http_scheme
error:
contains:
- https
- ssl
- tls
- scheme
- requires
- label: http_scheme
connection_not_established: true
AUTH-016 — Verifies that with mutual TLS enabled and both client-identity inputs supplied, a client certificate or private key that cannot be loaded is rejected at connect time: the driver reports which input f…
Expected (per the shared spec):
- full assertion contract:
result:
- label: cert_path_missing
error:
contains:
- clientcert
- client cert
- certificate
- label: cert_path_missing
connection_not_established: true
- label: key_path_missing
error:
contains:
- clientprivatekey
- private key
- label: key_path_missing
connection_not_established: true
- label: cert_file_empty
error:
contains:
- clientcert
- client cert
- certificate
- label: cert_file_empty
connection_not_established: true
- label: key_file_empty
error:
contains:
- clientprivatekey
- private key
- label: key_file_empty
connection_not_established: true
Context
- The behavior was first fixed in a DIFFERENT driver — reference PR: https://github.com/databricks/databricks-odbc/pull/337 — which seeded the shared language-neutral spec. This issue tracks the same conformance gap in databricks/databricks-sql-python; the reference PR is for cross-referencing the intended behavior, NOT a change to this repo.
- Coverage PR carrying the reproducing xfail test(s): https://github.com/databricks/databricks-driver-test/pull/1541
- Linguagem predominante
- Python
- Estrelas
- 233
- Forks
- 152
- Merge médio
- 21h 5min
- PRs com merge (30d)
- 10
Guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de databricks/databricks-sql-python
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 76/100
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 72/100
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 84/100
Todas as issues de databricks/databricks-sql-python
Issues semelhantes
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 75/100
anthropics/skills#1811 · 1 comentário ·
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 75/100
speaches-ai/speaches#678 ·
-
bug
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 75/100
datalayer/mcp-compose#42 ·
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 75/100
conda-forge/spacy-feedstock#177 ·
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 70/100
UKGovernmentBEIS/inspect_evals#2523 ·