[coverage] Conformance findings: AUTH-015,AUTH-016
Personne n'a encore pris cette issue.
Évaluation
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Accessibilité débutants
- 58/100
- Type d'issue
- Bug
- Clarté
- Plutôt claire
- Activité
- Active
- Stack technique
- python
- Domaine
- authentication, backend, security
Piste de recherche
Commencez par lire SSLOptions.create_ssl_context(), backend/kernel/client.py::_kernel_tls_kwargs et _read_pem_bytes, puis examinez UnifiedHttpClient._setup_pool_managers. Utilisez les tests xfail nommés dans la PR de couverture comme vérifications d’acceptation. C’est terminé lorsque AUTH-015 rejette les paramètres mTLS incomplets avant la connexion et que AUTH-016 signale l’entrée de certificat ou de clé privée concernée lorsque des fichiers sont manquants ou vides.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Description
Summary
Surfaced by the multi-language coverage fan-out while conformance-testing these SPEC-IDs against databricks/databricks-sql-python. Each finding is committed as an expected-failure (xfail) test in the coverage PR — the test asserts the CORRECT (post-fix) behavior and stays red until THIS driver (databricks/databricks-sql-python) is fixed, then flips green as a tripwire.
Findings
- AUTH-015 [thrift, sea]: a lone
_tls_client_cert_key_file(private key without client cert) is silently dropped and the connection proceeds over one-way TLS with no client identity instead of failing fast; both SSLOptions.create_ssl_context() and _kernel_tls_kwargs gate solely onif cert_file:, so the kernel's own cert/key pairing check is never reached- failing test:
test_mutual_tls_requires_client_certificate_alongside_private_key(see the coverage PR diff undertests/)
- failing test:
- AUTH-016 [thrift]: an unreadable or empty mTLS client-identity file fails with a raw stdlib error that does not identify which input failed (bare FileNotFoundError for a missing path,
SSLError: [SSL] PEM libfor an empty file) because UnifiedHttpClient._setup_pool_managers calls ssl_context.load_cert_chain with no try/except- failing test:
test_mutual_tls_rejects_unreadable_or_empty_client_identity_file(see the coverage PR diff undertests/)
- failing test:
- AUTH-016 [sea]: an unreadable or empty mTLS client-identity file fails with a raw stdlib error that does not identify which input failed; the kernel path's own diagnostics in _read_pem_bytes (which name tls_client_cert_file / tls_client_cert_key_file and the path) never surface because the unconditional UnifiedHttpClient build throws load_cert_chain's raw error first
- failing test:
test_mutual_tls_rejects_unreadable_or_empty_client_identity_file(see the coverage PR diff undertests/)
- failing test:
- AUTH-015: a lone
_tls_client_cert_key_file(private key without client cert) is silently dropped and the connection proceeds over one-way TLS with no client identity instead of failing fast; bothSSLOptions.create_ssl_context()andbackend/kernel/client.py::_kernel_tls_kwargsgate solely onif cert_file:, so the kernel's own "client_key_pem is set without client_cert_pem" pairing check is never reached - AUTH-016: an unreadable or empty mTLS client-identity file fails with a raw stdlib error that does not identify which input failed (
FileNotFoundError: [Errno 2] No such file or directoryfor a missing path,SSLError: [SSL] PEM libfor an empty file) becauseUnifiedHttpClient._setup_pool_managerscallsssl_context.load_cert_chain(cert, key, password)with no try/except; the kernel path's own diagnostics in_read_pem_bytes(which do nametls_client_cert_file/tls_client_cert_key_fileand the path) never surface since the unconditional UnifiedHttpClient build throws first
Reproduce & Expected
AUTH-015 — Verifies that enabling mutual TLS with an incomplete or contradictory configuration is rejected at connect time, before any connection is established — the driver fails fast rather than silently fall…
Expected (per the shared spec):
- full assertion contract:
result:
- label: missing_both
error:
contains:
- clientcert
- client cert
- certificate
- clientprivatekey
- private key
- required
- missing
- label: missing_both
connection_not_established: true
- label: missing_key
error:
contains:
- clientprivatekey
- private key
- required
- missing
- label: missing_key
connection_not_established: true
- label: missing_cert
error:
contains:
- clientcert
- client cert
- certificate
- required
- missing
- label: missing_cert
connection_not_established: true
- label: plaintext
error:
contains:
- ssl
- tls
- https
- requires
- label: plaintext
connection_not_established: true
- label: http_scheme
error:
contains:
- https
- ssl
- tls
- scheme
- requires
- label: http_scheme
connection_not_established: true
AUTH-016 — Verifies that with mutual TLS enabled and both client-identity inputs supplied, a client certificate or private key that cannot be loaded is rejected at connect time: the driver reports which input f…
Expected (per the shared spec):
- full assertion contract:
result:
- label: cert_path_missing
error:
contains:
- clientcert
- client cert
- certificate
- label: cert_path_missing
connection_not_established: true
- label: key_path_missing
error:
contains:
- clientprivatekey
- private key
- label: key_path_missing
connection_not_established: true
- label: cert_file_empty
error:
contains:
- clientcert
- client cert
- certificate
- label: cert_file_empty
connection_not_established: true
- label: key_file_empty
error:
contains:
- clientprivatekey
- private key
- label: key_file_empty
connection_not_established: true
Context
- The behavior was first fixed in a DIFFERENT driver — reference PR: https://github.com/databricks/databricks-odbc/pull/337 — which seeded the shared language-neutral spec. This issue tracks the same conformance gap in databricks/databricks-sql-python; the reference PR is for cross-referencing the intended behavior, NOT a change to this repo.
- Coverage PR carrying the reproducing xfail test(s): https://github.com/databricks/databricks-driver-test/pull/1541
- Langage dominant
- Python
- Étoiles
- 233
- Forks
- 152
- Merge moyen
- 21 h 5 min
- PR mergées (30 j)
- 10
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Autres issues de databricks/databricks-sql-python
-
Difficulté 2/5 1-3 heures Accessibilité débutants 78/100
-
Difficulté 2/5 1-3 heures Accessibilité débutants 76/100
-
Difficulté 2/5 1-3 heures Accessibilité débutants 78/100
-
Difficulté 2/5 1-3 heures Accessibilité débutants 72/100
-
Difficulté 2/5 1-3 heures Accessibilité débutants 84/100
Toutes les issues de databricks/databricks-sql-python
Issues similaires
-
essnmx good first issue
Difficulté 1/5 Moins d'une heure Accessibilité débutants 95/100
-
[Feature] 奇物选择添加优先级 Ouverte
Difficulté 2/5 1-3 heures Accessibilité débutants 65/100
syfoud/Simulated_Scepter#174 ·
-
Difficulté 2/5 1-3 heures Accessibilité débutants 75/100
Giskard-AI/giskard-oss#2840 · 1 commentaire ·
-
A claim comment carrying the issue number is silently declined while the workflow reports success Ouvertearea: repo bug perceived difficulty: 2
Difficulté 2/5 1-3 heures Accessibilité débutants 70/100
-
Difficulté 2/5 1-3 heures Accessibilité débutants 75/100
yeti-platform/yeti#1380 ·