Hacktoberfest 2026: as issues que os mantenedores marcaram para outubro, abertas e boas para iniciantes. Ver issues do Hacktoberfest

Remove the AGP 9 opt-outs once react-native-test-app supports them

Aberta
#389 0 comentários 0 reações 0 responsáveis Ver no GitHub

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
45/100
Tipo de issue
Refatoração
Clareza
Claramente especificada
Status de atividade
Pouca atividade
Stack de tecnologia
android, kotlin, react-native
Domínio
build-system, mobile

Direção de pesquisa

Comece por apps/test-app/android/gradle.properties e packages/host/android/build.gradle; depois, revise os arquivos Gradle do Android do react-native-test-app citados e os dois bloqueios da migração. Verifique as alterações do novo DSL no módulo host, preservando seu comportamento condicional para built-in-Kotlin, e execute as verificações de configuração e instalação do aplicativo de teste Android. O trabalho estará concluído quando ambos os opt-outs forem removidos e o aplicativo de teste continuar sendo configurado e instalado após a resolução dos bloqueios upstream.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Android 🤖

The test app sets both AGP 9 opt-outs in apps/test-app/android/gradle.properties:

android.builtInKotlin=false
android.newDsl=false

This issue tracks removing them. Both are blocked on react-native-test-app, not on us.

Correction. An earlier revision of this issue said we were "already off the sibling flag" and running built-in Kotlin natively. That was wrong — we tried it, the Android build failed, and #372 had to put android.builtInKotlin=false back. Details in blocker 1.

Deadline

Per Android's DSL/API migration timeline, AGP 10.0 (estimated late 2026) removes both opt-outs, along with the legacy APIs. Once React Native pins an AGP 10 these flags stop being a choice — the build either has migrated or it doesn't configure. That is plausibly one or two React Native minors away, so this is a when, not an if.

Blocker 1: built-in Kotlin — sources added via java.srcDirs are not compiled

react-native-test-app's app module adds its version-specific sources with main.java.srcDirs += [...]. The Kotlin plugin adds those directories to the Kotlin source set; AGP's built-in Kotlin only picks up the standard ones. Building with the flag unset (react-native-test-app 5.4.8, React Native 0.88 nightly, AGP 9.2.1) fails :app:compileReleaseKotlin:

e: ComponentActivity.kt:33:9 Unresolved reference 'ComponentActivityDelegate'
e: MainActivity.kt:145:9 Unresolved reference 'testApp'
e: MainActivity.kt:225:50 Unresolved reference 'reactHost'
e: MainActivity.kt:135:17 Unresolved reference 'canUseCamera'
e: MainActivity.kt:25:45 Unresolved reference 'ComponentBottomSheetDialogFragment'

Every unresolved symbol lives in an added directory — src/reactactivitydelegate-0.75/java, src/reactapplication-0.76/java, src/reacthost-0.76/java, src/camera/java. Files under the standard src/main/java compile fine. Their useBuiltInKotlin gate avoids applying the Kotlin plugin on top of built-in Kotlin, but the module still needs that plugin to compile at all.

Likely fix upstream: add the same directories to main.kotlin.srcDirs.

Our own half is already done. react-native-node-api applies the Kotlin plugin only when built-in Kotlin is unavailable, so the published library works under either regime no matter what the harness needs. That shipped in #372 and waits on nothing.

Blocker 2: the new DSL

Both react-native-test-app modules still use the old DSL, permalinked at 5.4.8:

Location Old DSL
android/app/build.gradle#L77 compileSdkVersion
android/app/build.gradle#L88 kotlinOptions (gated on !useBuiltInKotlin)
android/app/build.gradle#L95-L96 minSdkVersion, targetSdkVersion
android/app/build.gradle#L161 lintOptions
android/support/build.gradle#L16 compileSdkVersion
android/support/build.gradle#L19-L20 minSdkVersion, targetSdkVersion

packages/host/android/build.gradle is old DSL too, and this half is ours. It matters beyond our CI: it is the published library, so it has to be new-DSL clean before consumers can migrate — the same shape as the built-in Kotlin problem that file already solves.

  • #L52, #L69 — script-style apply plugin: instead of a plugins {} block
  • #L101 — compileSdkVersion
  • #L109-L110 — minSdkVersion, targetSdkVersion
  • #L154 — lintOptions

Ordering

The flags are coupled one way: builtInKotlin=false requires newDsl=false, because the Kotlin plugin is incompatible with the new DSL. So blocker 1 has to be resolved before blocker 2 can be — though each piece of work is independently useful, and our own module can move to the new DSL at any time.

Nothing upstream tracks either blocker yet. Whether to file it, and the paste-ready text, is #390.

Done when

Both lines are gone from apps/test-app/android/gradle.properties and the Android test app still configures and installs.


Introduced by #372. Links into this repo point at main and are accurate as of that PR merging.

Linguagem predominante
TypeScript
Estrelas
188
Forks
10
Merge médio
2d 17h
PRs com merge (30d)
3

Guia de contribuição

Nenhum guia de contribuição indexado para este repositório

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de callstackincubator/react-native-node-api

Todas as issues de callstackincubator/react-native-node-api

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.