Remove the AGP 9 opt-outs once react-native-test-app supports them
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 45/100
- Tipo di issue
- Refactoring
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Tranquilla
- Stack tecnologico
- android, kotlin, react-native
- Ambito
- build-system, mobile
Direzione di ricerca
Inizia da apps/test-app/android/gradle.properties e packages/host/android/build.gradle, poi esamina i file Gradle Android di react-native-test-app citati e i due blocchi della migrazione. Verifica le modifiche al nuovo DSL del modulo host, preservando il suo comportamento condizionale per built-in-Kotlin, ed esegui i controlli di configurazione e installazione dell’app di test Android. Il lavoro è completato quando entrambi gli opt-out sono stati rimossi e l’app di test continua a configurarsi e installarsi dopo la risoluzione dei blocchi upstream.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
The test app sets both AGP 9 opt-outs in apps/test-app/android/gradle.properties:
android.builtInKotlin=false
android.newDsl=false
This issue tracks removing them. Both are blocked on react-native-test-app, not on us.
Correction. An earlier revision of this issue said we were "already off the sibling flag" and running built-in Kotlin natively. That was wrong — we tried it, the Android build failed, and #372 had to put
android.builtInKotlin=falseback. Details in blocker 1.
Deadline
Per Android's DSL/API migration timeline, AGP 10.0 (estimated late 2026) removes both opt-outs, along with the legacy APIs. Once React Native pins an AGP 10 these flags stop being a choice — the build either has migrated or it doesn't configure. That is plausibly one or two React Native minors away, so this is a when, not an if.
Blocker 1: built-in Kotlin — sources added via java.srcDirs are not compiled
react-native-test-app's app module adds its version-specific sources with main.java.srcDirs += [...]. The Kotlin plugin adds those directories to the Kotlin source set; AGP's built-in Kotlin only picks up the standard ones. Building with the flag unset (react-native-test-app 5.4.8, React Native 0.88 nightly, AGP 9.2.1) fails :app:compileReleaseKotlin:
e: ComponentActivity.kt:33:9 Unresolved reference 'ComponentActivityDelegate'
e: MainActivity.kt:145:9 Unresolved reference 'testApp'
e: MainActivity.kt:225:50 Unresolved reference 'reactHost'
e: MainActivity.kt:135:17 Unresolved reference 'canUseCamera'
e: MainActivity.kt:25:45 Unresolved reference 'ComponentBottomSheetDialogFragment'
Every unresolved symbol lives in an added directory — src/reactactivitydelegate-0.75/java, src/reactapplication-0.76/java, src/reacthost-0.76/java, src/camera/java. Files under the standard src/main/java compile fine. Their useBuiltInKotlin gate avoids applying the Kotlin plugin on top of built-in Kotlin, but the module still needs that plugin to compile at all.
Likely fix upstream: add the same directories to main.kotlin.srcDirs.
Our own half is already done. react-native-node-api applies the Kotlin plugin only when built-in Kotlin is unavailable, so the published library works under either regime no matter what the harness needs. That shipped in #372 and waits on nothing.
Blocker 2: the new DSL
Both react-native-test-app modules still use the old DSL, permalinked at 5.4.8:
| Location | Old DSL |
|---|---|
android/app/build.gradle#L77 |
compileSdkVersion |
android/app/build.gradle#L88 |
kotlinOptions (gated on !useBuiltInKotlin) |
android/app/build.gradle#L95-L96 |
minSdkVersion, targetSdkVersion |
android/app/build.gradle#L161 |
lintOptions |
android/support/build.gradle#L16 |
compileSdkVersion |
android/support/build.gradle#L19-L20 |
minSdkVersion, targetSdkVersion |
packages/host/android/build.gradle is old DSL too, and this half is ours. It matters beyond our CI: it is the published library, so it has to be new-DSL clean before consumers can migrate — the same shape as the built-in Kotlin problem that file already solves.
#L52,#L69— script-styleapply plugin:instead of aplugins {}block#L101—compileSdkVersion#L109-L110—minSdkVersion,targetSdkVersion#L154—lintOptions
Ordering
The flags are coupled one way: builtInKotlin=false requires newDsl=false, because the Kotlin plugin is incompatible with the new DSL. So blocker 1 has to be resolved before blocker 2 can be — though each piece of work is independently useful, and our own module can move to the new DSL at any time.
Nothing upstream tracks either blocker yet. Whether to file it, and the paste-ready text, is #390.
Done when
Both lines are gone from apps/test-app/android/gradle.properties and the Android test app still configures and installs.
Introduced by #372. Links into this repo point at main and are accurate as of that PR merging.
- Lingua principale
- TypeScript
- Stelle
- 188
- Fork
- 10
- Merge medio
- 2g 17h
- PR unite (30g)
- 3
Guida per i contributori
Nessuna guida per i contributori indicizzata per questo repository
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di callstackincubator/react-native-node-api
-
Android 🤖
Difficoltà 2/5 1-3 ore Idoneità per principianti 66/100
-
Sanity check of Hermes source directory via environment variable, when building Android projects ApertaAndroid 🤖 good first issue
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
callstackincubator/react-native-node-api#163 · 1 commento ·
-
enhancement good first issue gyp-to-cmake
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
callstackincubator/react-native-node-api#161 · 3 commenti · 1 reazione ·
-
enhancement Host 🏡
Difficoltà 5/5 Più di una settimana Idoneità per principianti 25/100
-
Automatable good first issue
Difficoltà 3/5 1-2 giorni Idoneità per principianti 15/100
callstackincubator/react-native-node-api#424 · 1 commento ·
Tutte le issue di callstackincubator/react-native-node-api
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 65/100
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
-
bug v2
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
modelcontextprotocol/inspector#2458 · 1 commento ·
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 75/100
railmapgen/rmp-gallery#4068 ·
-
Mend: dependency security vulnerability status: needs triage 🕵️♀️
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
carbon-design-system/ibm-products#9907 ·