Hacktoberfest 2026: as issues que os mantenedores marcaram para outubro, abertas e boas para iniciantes. Ver issues do Hacktoberfest

iOS live-lane retry policy (from #3336 review): scope re-issue to declared reads, count absorbed misses, build wire-shape fixtures

Aberta
  • Algo errado?
#3,344 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
48/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
ios, typescript
Domínio
mobile, testing

Direção de pesquisa

Start with test/integration/ios-simulator-e2e/live-harness.ts and trace how runStep sets the re-issue predicate; read resolveCommandRecordingEffect to identify the declared read effect. Then inspect runtime.ts and test/integration/ios-simulator-e2e-step-retry-policy.test.ts, including waitFailure(), for the miss-counting and fixture work. Done when retries are limited to observing steps, absorbed misses are countable, and fixtures reflect the wire response.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Why

Three follow-up notes from the human review of #3336 (reviewer comment 2026-10-08T22:38:43Z; the lane-policy layer shipped there is row 8's subject matter in #2491). None blocks the PR; all three outlive it, so they live here instead of a comment thread.

Scope

  1. Scope the re-issue predicate to declared reads. runStep in test/integration/ios-simulator-e2e/live-harness.ts attaches isObservationPreventedStepMiss to EVERY iOS step. A replay step's failure response is the failed step's OWN wire response passed through verbatim (readLastResponse() in packages/replay-port/src/daemon-port/native-command.ts), so a nested wait's retriable: true + details.reason hoists to the top level and could re-run a whole script after earlier mutating steps. Today that is benign (every lane replay starts with open --relaunch or launchApp clearState), and it cannot stack with the test suite's --retries: a scheduler-level suite failure is built as errorResponse(code, message) without details/retriable (packages/replay-port/src/daemon-port/test-command.ts), and a completed-with-failures suite returns ok:true counts the harness asserts itself. The scoping rule the reviewer proposed: re-issue only steps whose command declares the read effect (resolveCommandRecordingEffect(step) === 'observes-app'), so hoisting can never reach a mutating step even after fixture changes.
  2. Make absorbed misses countable. A re-issue that turns a step green records the first failure only inside step-history.json (runtime.ts runStep, issue > 1). One stderr line or JUnit annotation keyed on the typed reason (error.details.reason + retriable) would let #2491 count absorbed misses per class instead of grepping step histories.
  3. Build the retry-policy fixtures from the wire, not by hand. waitFailure() in test/integration/ios-simulator-e2e-step-retry-policy.test.ts hand-writes the response shape. It currently matches the recorded payload (run 37356199982: top-level retriable: true, details.reason: wait_runner_restart_exhausted), but building fixtures via normalizeError or a recorded CLI payload keeps them honest if the envelope moves.

Related: #2491, #3336.

Linguagem predominante
TypeScript
Estrelas
4.9k
Forks
328
Merge médio
12h 16min
PRs com merge (30d)
538

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de callstack/agent-device

Todas as issues de callstack/agent-device

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.