Pin the recovery --delay-ms constant across the Swift hint and the TS help text

Fechada
  • Algo errado?
#3,360 1 comentário 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

@thymikee já está trabalhando nisso.

Desde 20/10/2026.

  • #3856 de @thymikee — aberto

Avaliação

Dificuldade
3/5
Tempo estimado
Meio dia
Facilidade para iniciantes
42/100
Tipo de issue
Refatoração
Clareza
Razoavelmente clara
Status de atividade
Ativa
Stack de tecnologia
markdown, swift, typescript
Domínio
testing-qa

Direção de pesquisa

Start at TextEntryTiming.recoveryDelayMilliseconds in apple/runner/AgentDeviceRunner/AgentDeviceRunnerUITests/RunnerTests+TextEntry.swift (value 80 at line 114) and at the hard-coded --delay-ms 80 in src/commands/schema/cli-help-workflows.ts, then read the golden fixtures under contracts/fixtures/ and AGENTS.md for the cross-language pattern. Done means one declared source for the value, the help text and website/docs/docs/commands.md consuming it, and a check in pnpm check:affected that fails when the Swift constant changes without the help text.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

refactor

The Apple runner builds its TEXT_INPUT_COMMIT_NOT_OBSERVED hint from TextEntryTiming.recoveryDelayMilliseconds (apple/runner/AgentDeviceRunner/AgentDeviceRunnerUITests/RunnerTests+TextEntry.swift:36, value 80 at :114). The versioned help paragraph introduced in #3334 hard-codes the same number as --delay-ms 80 in src/commands/schema/cli-help-workflows.ts (website/docs/docs/commands.md mirrors it). TS cannot import a Swift constant, so the two can drift silently.

Required behavior: the number is stated once and both surfaces consume it — the cross-language golden tables under contracts/fixtures/ are the mechanism AGENTS.md already prescribes for shared cross-language rules; extend that pattern (or an equivalent single-source check under scripts/) so changing the Swift constant must fail a gate until the help text moves with it.

Completion condition: changing recoveryDelayMilliseconds in Swift without updating the help text fails pnpm check:affected (or a dedicated check), and the current value 80 appears in exactly one declared source plus the generated/pinned projection.

Found by review on #3334 (non-blocking); intentionally not fixed there to keep that PR inside the fill command family.

Linguagem predominante
TypeScript
Estrelas
5.3k
Forks
377
Merge médio
14h 6min
PRs com merge (30d)
650

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de callstack/agent-device

Todas as issues de callstack/agent-device

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.