`make` doesn't work cloudformation-cli latest versions causing `cfn submit` to fail

Aberta
#1,053 4 comentários 0 reações 0 responsáveis Ver no GitHub

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
35/100
Tipo de issue
Bug
Clareza
Razoavelmente clara
Status de atividade
Estagnada
Stack de tecnologia
aws, go, python
Domínio
cli, cloud, tooling

Direção de pesquisa

Comece em rpdk/go/codegen.py, especialmente em package e _find_exe, usando os comandos cfn submit e make relatados com cloudformation-cli 0.2.34 ou 0.2.35 e o plugin Go 2.2.0. Compare o comportamento com as versões 0.2.33 e 2.0.4. Está concluído quando make produz um executável Go localizável e cfn submit empacota e envia o recurso sem GoExecutableNotFoundError.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Hi

We are running into errors when submitting a CFN resource to private registry. Essentially it looks like an issue with the make command in cloudformation-cli.

We noticed that the issue does not occur in below versions:
cloudformation-cli==0.2.33
cloudformation-cli-go-plugin==2.0.4

The issue occurs if the latest versions of the CLI are used i.e. cloudformation-cli v0.2.34 and v0.2.35 and cloudformation-cli-go-plugin v2.2.0

Expected Behavior:

  • cfn submit should submit the resource to private registry without errors

Actual Behavior:

  • cfn submit give below error no matter how many times we run make/cfn submit
cfn submit --region eu-south-1
Resource schema is valid.
You must build the handler before running cfn-submit.
Please run 'make' or the equivalent command in your IDE to compile and package the code.

rpdk.log:

[2023-12-29T11:23:40Z] DEBUG    - inputs_1_update.json found. Writing to package.
[2023-12-29T11:23:40Z] INFO     - Packaging Go project
[2023-12-29T11:23:40Z] DEBUG    - No Go executable match
[2023-12-29T11:23:40Z] DEBUG    - Caught exit recommendation
Traceback (most recent call last):
  File "/opt/homebrew/lib/python3.11/site-packages/rpdk/core/cli.py", line 105, in main
    args.command(args)
  File "/opt/homebrew/lib/python3.11/site-packages/rpdk/core/submit.py", line 19, in submit
    project.submit(
  File "/opt/homebrew/lib/python3.11/site-packages/rpdk/core/project.py", line 652, in submit
    self._add_resources_content_to_zip(zip_file)
  File "/opt/homebrew/lib/python3.11/site-packages/rpdk/core/project.py", line 686, in _add_resources_content_to_zip
    self._plugin.package(self, zip_file)
  File "/opt/homebrew/lib/python3.11/site-packages/rpdk/go/codegen.py", line 281, in package
    self._find_exe(project)
  File "/opt/homebrew/lib/python3.11/site-packages/rpdk/go/codegen.py", line 257, in _find_exe
    raise GoExecutableNotFoundError(
rpdk.go.codegen.GoExecutableNotFoundError: You must build the handler before running cfn-submit.
Please run 'make' or the equivalent command in your IDE to compile and package the code.
[2023-12-29T11:23:40Z] CRITICAL - You must build the handler before running cfn-submit.
Please run 'make' or the equivalent command in your IDE to compile and package the code.
[2023-12-29T14:54:34Z] DEBUG    - Logging set up successfully
[2023-12-29T14:54:34Z] DEBUG    - Running generate: Namespace(version=False, subparser_name='generate', command=<function generate at 0x12244ce00>, verbose=0, endpoint_url=None, region=None, local_only=False, target_schemas=[], profile=None)
[2023-12-29T14:54:34Z] DEBUG    - Root directory: /Users/aastha.mahendru/mongodbatlas-cloudformation-resources/cfn-resources/network-container
[2023-12-29T14:54:34Z] DEBUG    - Loading project file '/Users/aastha.mahendru/mongodbatlas-cloudformation-resources/cfn-resources/network-container/.rpdk-config'
[2023-12-29T14:54:34Z] INFO     - Validating your resource specification...
[2023-12-29T14:54:34Z] DEBUG    - Rewriting refs in '<BASE>' (file:///Users/aastha.mahendru/mongodbatlas-cloudformation-resources/cfn-resources/network-container/mongodb-atlas-networkcontainer.json)
[2023-12-29T14:54:34Z] WARNING  - Resource schema is valid.
[2023-12-29T14:54:34Z] INFO     - Validating your resource schema...
[2023-12-29T14:54:34Z] DEBUG    - Writing Execution Role CloudFormation template: /Users/aastha.mahendru/mongodbatlas-cloudformation-resources/cfn-resources/network-container/resource-role.yaml
[2023-12-29T14:54:34Z] DEBUG    - Overwriting '/Users/aastha.mahendru/mongodbatlas-cloudformation-resources/cfn-resources/network-container/resource-role.yaml'
[2023-12-29T14:54:34Z] DEBUG    - Generate started
[2023-12-29T14:54:34Z] DEBUG    - Writing Types
[2023-12-29T14:54:34Z] DEBUG    - Overwriting '/Users/aastha.mahendru/mongodbatlas-cloudformation-resources/cfn-resources/network-container/cmd/resource/config.go'
[2023-12-29T14:54:34Z] DEBUG    - Overwriting '/Users/aastha.mahendru/mongodbatlas-cloudformation-resources/cfn-resources/network-container/cmd/resource/model.go'
[2023-12-29T14:54:34Z] DEBUG    - Writing project: /Users/aastha.mahendru/mongodbatlas-cloudformation-resources/cfn-resources/network-container/cmd/main.go
[2023-12-29T14:54:34Z] DEBUG    - Overwriting '/Users/aastha.mahendru/mongodbatlas-cloudformation-resources/cfn-resources/network-container/cmd/main.go'
[2023-12-29T14:54:34Z] DEBUG    - Writing makebuild: /Users/aastha.mahendru/mongodbatlas-cloudformation-resources/cfn-resources/network-container/makebuild
[2023-12-29T14:54:34Z] DEBUG    - Overwriting '/Users/aastha.mahendru/mongodbatlas-cloudformation-resources/cfn-resources/network-container/makebuild'
[2023-12-29T14:54:34Z] DEBUG    - Removing generated docs: /Users/aastha.mahendru/mongodbatlas-cloudformation-resources/cfn-resources/network-container/docs
[2023-12-29T14:54:34Z] DEBUG    - Writing generated docs
[2023-12-29T14:54:34Z] DEBUG    - Finished documenting nested properties
[2023-12-29T14:54:34Z] DEBUG    - Writing docs README: /Users/aastha.mahendru/mongodbatlas-cloudformation-resources/cfn-resources/network-container/docs/README.md
[2023-12-29T14:54:34Z] WARNING  - Generated files for MongoDB::Atlas::NetworkContainer
[2023-12-29T14:54:34Z] DEBUG    - Finished generate
[2023-12-29T14:54:42Z] DEBUG    - Logging set up successfully
[2023-12-29T14:54:42Z] DEBUG    - Running submit: Namespace(version=False, subparser_name='submit', command=<function submit at 0x1168e1440>, verbose=0, dry_run=False, endpoint_url=None, region='eu-south-1', set_default=False, profile=None, role_arn=None, use_role=True, use_docker=False, no_docker=False)
[2023-12-29T14:54:42Z] DEBUG    - Root directory: /Users/aastha.mahendru/mongodbatlas-cloudformation-resources/cfn-resources/network-container
[2023-12-29T14:54:42Z] DEBUG    - Loading project file '/Users/aastha.mahendru/mongodbatlas-cloudformation-resources/cfn-resources/network-container/.rpdk-config'
[2023-12-29T14:54:42Z] INFO     - Validating your resource specification...
[2023-12-29T14:54:42Z] DEBUG    - Rewriting refs in '<BASE>' (file:///Users/aastha.mahendru/mongodbatlas-cloudformation-resources/cfn-resources/network-container/mongodb-atlas-networkcontainer.json)
[2023-12-29T14:54:42Z] WARNING  - Resource schema is valid.
[2023-12-29T14:54:42Z] INFO     - Validating your resource schema...
[2023-12-29T14:54:42Z] DEBUG    - inputs_1_create.json found. Writing to package.
[2023-12-29T14:54:42Z] DEBUG    - inputs_1_update.json found. Writing to package.
[2023-12-29T14:54:42Z] INFO     - Packaging Go project
[2023-12-29T14:54:42Z] DEBUG    - No Go executable match
[2023-12-29T14:54:42Z] DEBUG    - Caught exit recommendation
Traceback (most recent call last):
  File "/opt/homebrew/lib/python3.11/site-packages/rpdk/core/cli.py", line 105, in main
    args.command(args)
  File "/opt/homebrew/lib/python3.11/site-packages/rpdk/core/submit.py", line 19, in submit
    project.submit(
  File "/opt/homebrew/lib/python3.11/site-packages/rpdk/core/project.py", line 652, in submit
    self._add_resources_content_to_zip(zip_file)
  File "/opt/homebrew/lib/python3.11/site-packages/rpdk/core/project.py", line 686, in _add_resources_content_to_zip
    self._plugin.package(self, zip_file)
  File "/opt/homebrew/lib/python3.11/site-packages/rpdk/go/codegen.py", line 281, in package
    self._find_exe(project)
  File "/opt/homebrew/lib/python3.11/site-packages/rpdk/go/codegen.py", line 257, in _find_exe
    raise GoExecutableNotFoundError(
rpdk.go.codegen.GoExecutableNotFoundError: You must build the handler before running cfn-submit.
Please run 'make' or the equivalent command in your IDE to compile and package the code.
[2023-12-29T14:54:42Z] CRITICAL - You must build the handler before running cfn-submit.
Please run 'make' or the equivalent command in your IDE to compile and package the code.
Linguagem predominante
Python
Estrelas
336
Forks
173
Métricas de merge de PRs
Nenhum PR com merge em 30d

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de aws-cloudformation/cloudformation-cli

Todas as issues de aws-cloudformation/cloudformation-cli

Issues semelhantes

Mais issues de Python

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.