`make` doesn't work cloudformation-cli latest versions causing `cfn submit` to fail

オープン
#1,053 コメント 4 件 リアクション 0 件 担当者 0 名 GitHub で見る

まだ誰も着手していません。

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
35/100
issue の種類
バグ
明瞭さ
おおむね明確
活発さ
停滞
技術スタック
aws, go, python
領域
cli, cloud, tooling

調査の方向性

rpdk/go/codegen.py から始め、特に package と _find_exe を確認し、cloudformation-cli 0.2.34 または 0.2.35 と Go plugin 2.2.0 を使用して報告された cfn submit および make コマンドを実行します。バージョン 0.2.33 および 2.0.4 と動作を比較します。make によって検出可能な Go 実行可能ファイルが生成され、cfn submit が GoExecutableNotFoundError なしでリソースをパッケージ化して送信できれば完了です。

索引モデルが issue の本文から書いたものです。

説明

Hi

We are running into errors when submitting a CFN resource to private registry. Essentially it looks like an issue with the make command in cloudformation-cli.

We noticed that the issue does not occur in below versions:
cloudformation-cli==0.2.33
cloudformation-cli-go-plugin==2.0.4

The issue occurs if the latest versions of the CLI are used i.e. cloudformation-cli v0.2.34 and v0.2.35 and cloudformation-cli-go-plugin v2.2.0

Expected Behavior:

  • cfn submit should submit the resource to private registry without errors

Actual Behavior:

  • cfn submit give below error no matter how many times we run make/cfn submit
cfn submit --region eu-south-1
Resource schema is valid.
You must build the handler before running cfn-submit.
Please run 'make' or the equivalent command in your IDE to compile and package the code.

rpdk.log:

[2023-12-29T11:23:40Z] DEBUG    - inputs_1_update.json found. Writing to package.
[2023-12-29T11:23:40Z] INFO     - Packaging Go project
[2023-12-29T11:23:40Z] DEBUG    - No Go executable match
[2023-12-29T11:23:40Z] DEBUG    - Caught exit recommendation
Traceback (most recent call last):
  File "/opt/homebrew/lib/python3.11/site-packages/rpdk/core/cli.py", line 105, in main
    args.command(args)
  File "/opt/homebrew/lib/python3.11/site-packages/rpdk/core/submit.py", line 19, in submit
    project.submit(
  File "/opt/homebrew/lib/python3.11/site-packages/rpdk/core/project.py", line 652, in submit
    self._add_resources_content_to_zip(zip_file)
  File "/opt/homebrew/lib/python3.11/site-packages/rpdk/core/project.py", line 686, in _add_resources_content_to_zip
    self._plugin.package(self, zip_file)
  File "/opt/homebrew/lib/python3.11/site-packages/rpdk/go/codegen.py", line 281, in package
    self._find_exe(project)
  File "/opt/homebrew/lib/python3.11/site-packages/rpdk/go/codegen.py", line 257, in _find_exe
    raise GoExecutableNotFoundError(
rpdk.go.codegen.GoExecutableNotFoundError: You must build the handler before running cfn-submit.
Please run 'make' or the equivalent command in your IDE to compile and package the code.
[2023-12-29T11:23:40Z] CRITICAL - You must build the handler before running cfn-submit.
Please run 'make' or the equivalent command in your IDE to compile and package the code.
[2023-12-29T14:54:34Z] DEBUG    - Logging set up successfully
[2023-12-29T14:54:34Z] DEBUG    - Running generate: Namespace(version=False, subparser_name='generate', command=<function generate at 0x12244ce00>, verbose=0, endpoint_url=None, region=None, local_only=False, target_schemas=[], profile=None)
[2023-12-29T14:54:34Z] DEBUG    - Root directory: /Users/aastha.mahendru/mongodbatlas-cloudformation-resources/cfn-resources/network-container
[2023-12-29T14:54:34Z] DEBUG    - Loading project file '/Users/aastha.mahendru/mongodbatlas-cloudformation-resources/cfn-resources/network-container/.rpdk-config'
[2023-12-29T14:54:34Z] INFO     - Validating your resource specification...
[2023-12-29T14:54:34Z] DEBUG    - Rewriting refs in '<BASE>' (file:///Users/aastha.mahendru/mongodbatlas-cloudformation-resources/cfn-resources/network-container/mongodb-atlas-networkcontainer.json)
[2023-12-29T14:54:34Z] WARNING  - Resource schema is valid.
[2023-12-29T14:54:34Z] INFO     - Validating your resource schema...
[2023-12-29T14:54:34Z] DEBUG    - Writing Execution Role CloudFormation template: /Users/aastha.mahendru/mongodbatlas-cloudformation-resources/cfn-resources/network-container/resource-role.yaml
[2023-12-29T14:54:34Z] DEBUG    - Overwriting '/Users/aastha.mahendru/mongodbatlas-cloudformation-resources/cfn-resources/network-container/resource-role.yaml'
[2023-12-29T14:54:34Z] DEBUG    - Generate started
[2023-12-29T14:54:34Z] DEBUG    - Writing Types
[2023-12-29T14:54:34Z] DEBUG    - Overwriting '/Users/aastha.mahendru/mongodbatlas-cloudformation-resources/cfn-resources/network-container/cmd/resource/config.go'
[2023-12-29T14:54:34Z] DEBUG    - Overwriting '/Users/aastha.mahendru/mongodbatlas-cloudformation-resources/cfn-resources/network-container/cmd/resource/model.go'
[2023-12-29T14:54:34Z] DEBUG    - Writing project: /Users/aastha.mahendru/mongodbatlas-cloudformation-resources/cfn-resources/network-container/cmd/main.go
[2023-12-29T14:54:34Z] DEBUG    - Overwriting '/Users/aastha.mahendru/mongodbatlas-cloudformation-resources/cfn-resources/network-container/cmd/main.go'
[2023-12-29T14:54:34Z] DEBUG    - Writing makebuild: /Users/aastha.mahendru/mongodbatlas-cloudformation-resources/cfn-resources/network-container/makebuild
[2023-12-29T14:54:34Z] DEBUG    - Overwriting '/Users/aastha.mahendru/mongodbatlas-cloudformation-resources/cfn-resources/network-container/makebuild'
[2023-12-29T14:54:34Z] DEBUG    - Removing generated docs: /Users/aastha.mahendru/mongodbatlas-cloudformation-resources/cfn-resources/network-container/docs
[2023-12-29T14:54:34Z] DEBUG    - Writing generated docs
[2023-12-29T14:54:34Z] DEBUG    - Finished documenting nested properties
[2023-12-29T14:54:34Z] DEBUG    - Writing docs README: /Users/aastha.mahendru/mongodbatlas-cloudformation-resources/cfn-resources/network-container/docs/README.md
[2023-12-29T14:54:34Z] WARNING  - Generated files for MongoDB::Atlas::NetworkContainer
[2023-12-29T14:54:34Z] DEBUG    - Finished generate
[2023-12-29T14:54:42Z] DEBUG    - Logging set up successfully
[2023-12-29T14:54:42Z] DEBUG    - Running submit: Namespace(version=False, subparser_name='submit', command=<function submit at 0x1168e1440>, verbose=0, dry_run=False, endpoint_url=None, region='eu-south-1', set_default=False, profile=None, role_arn=None, use_role=True, use_docker=False, no_docker=False)
[2023-12-29T14:54:42Z] DEBUG    - Root directory: /Users/aastha.mahendru/mongodbatlas-cloudformation-resources/cfn-resources/network-container
[2023-12-29T14:54:42Z] DEBUG    - Loading project file '/Users/aastha.mahendru/mongodbatlas-cloudformation-resources/cfn-resources/network-container/.rpdk-config'
[2023-12-29T14:54:42Z] INFO     - Validating your resource specification...
[2023-12-29T14:54:42Z] DEBUG    - Rewriting refs in '<BASE>' (file:///Users/aastha.mahendru/mongodbatlas-cloudformation-resources/cfn-resources/network-container/mongodb-atlas-networkcontainer.json)
[2023-12-29T14:54:42Z] WARNING  - Resource schema is valid.
[2023-12-29T14:54:42Z] INFO     - Validating your resource schema...
[2023-12-29T14:54:42Z] DEBUG    - inputs_1_create.json found. Writing to package.
[2023-12-29T14:54:42Z] DEBUG    - inputs_1_update.json found. Writing to package.
[2023-12-29T14:54:42Z] INFO     - Packaging Go project
[2023-12-29T14:54:42Z] DEBUG    - No Go executable match
[2023-12-29T14:54:42Z] DEBUG    - Caught exit recommendation
Traceback (most recent call last):
  File "/opt/homebrew/lib/python3.11/site-packages/rpdk/core/cli.py", line 105, in main
    args.command(args)
  File "/opt/homebrew/lib/python3.11/site-packages/rpdk/core/submit.py", line 19, in submit
    project.submit(
  File "/opt/homebrew/lib/python3.11/site-packages/rpdk/core/project.py", line 652, in submit
    self._add_resources_content_to_zip(zip_file)
  File "/opt/homebrew/lib/python3.11/site-packages/rpdk/core/project.py", line 686, in _add_resources_content_to_zip
    self._plugin.package(self, zip_file)
  File "/opt/homebrew/lib/python3.11/site-packages/rpdk/go/codegen.py", line 281, in package
    self._find_exe(project)
  File "/opt/homebrew/lib/python3.11/site-packages/rpdk/go/codegen.py", line 257, in _find_exe
    raise GoExecutableNotFoundError(
rpdk.go.codegen.GoExecutableNotFoundError: You must build the handler before running cfn-submit.
Please run 'make' or the equivalent command in your IDE to compile and package the code.
[2023-12-29T14:54:42Z] CRITICAL - You must build the handler before running cfn-submit.
Please run 'make' or the equivalent command in your IDE to compile and package the code.
主要言語
Python
スター
336
フォーク
173
PR マージ指標
30日以内にマージされた PR はありません

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

aws-cloudformation/cloudformation-cli のほかの issue

aws-cloudformation/cloudformation-cli の issue をすべて見る

似ている issue

Python の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。