VR command aggregation drops commands and fails with NPE when two jobs aggregate on the same router

Aberta
  • Algo errado?
#14,639 1 comentário 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

@bhouse-nexthop já está trabalhando nisso.

Desde 9/11/2026.

  • #14640 de @bhouse-nexthop — aberto

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
55/100
Tipo de issue
Bug
Clareza
Razoavelmente clara
Status de atividade
Ativa
Stack de tecnologia
java
Domínio
cloud, infrastructure

Direção de pesquisa

Start with core/.../agent/resource/virtualnetwork/VirtualRoutingResource.java and trace how AggregationControlCommand Start and Finish access the per-router queue, _vrLockMap, and aggregation map. Check the agent request threading and related tests before changing these shared maps. Done means concurrent aggregation for one router does not replace or misapply queued commands, create inconsistent locks, or fail when Finish finds no queue; add coverage for those cases.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

problem

Command aggregation on a virtual router isn't safe when two jobs aggregate commands for the same router at the same time. Parallel tier deploys in one VPC do this. Commands get dropped, and jobs fail with a NullPointerException.

VirtualRoutingResource (core/.../agent/resource/virtualnetwork/VirtualRoutingResource.java) keeps one aggregation queue per router name in a HashMap:

  • AggregationControlCommand Start puts a new queue for the router. A second Start while one exists replaces it, so the commands the first job has queued so far are never applied. Their answers were already successful, because a queued command is answered with success at once.
  • Every other NetworkElementCommand for that router goes into whichever queue is current.
  • Finish applies the current queue and removes it. The first job's Finish applies the second job's queue, and the second job's Finish then finds no queue. The loop and then queue.clear() in the finally block throw java.lang.NullPointerException: Cannot invoke "java.util.Queue.clear()" because "queue" is null.

The result is that one job fails, and another reports success although some of its configuration never reached the router.

The per-router lock map (_vrLockMap) and the aggregation map are also plain HashMaps changed from parallel agent request threads. The lock is created with a check-then-put, so two threads can get different locks for the same router.

This may be one cause of #11710: with redundant routers, the two routers of a VPC can end up with different configurations.

versions

4.22 (the code is the same on main and 4.20).

The steps to reproduce the bug
  1. Create a VPC with redundant routers on KVM.
  2. Create several tiers and deploy VMs into them in parallel, for example 24 deploys across the tiers at once.
  3. Some deploys fail. The management server logs Failed to re-program the network as a part of network ... implement due to aggregated commands execution failure!, and the router's host agent answers an AggregationControlCommand Finish with java.lang.NullPointerException: Cannot invoke "java.util.Queue.clear()" because "queue" is null.
  4. In our lab run, 12 of 24 parallel tier deploys failed. In two of three rounds, the two routers ended up with different keepalived VIP sets, and both were PRIMARY.
What to do about it?
  • On the agent:
    • do not replace an existing queue on Start;
    • do not fail with an NPE on a Finish whose queue was already applied;
    • make the maps thread-safe.
  • A complete fix would serialise aggregated applies per router on the management server, or tag each aggregation with an id. That is a larger change.
Linguagem predominante
Java
Estrelas
3.1k
Forks
1.4k
Merge médio
7d 16h
PRs com merge (30d)
15

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de apache/cloudstack

Todas as issues de apache/cloudstack

Issues semelhantes

Mais issues de Java

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.