psql tab completion broken for storage servers, tags, profiles and resource groups (pre-PG15 query format)
I maintainer di solito rispondono entro 2 giorni
Valutazione
- Difficoltà
- 2/5
- Tempo stimato
- 1-3 ore
- Idoneità per principianti
- 72/100
Direzione di ricerca
Le quattro macro Query_for_list_of_tags, Query_for_list_of_resgroups, Query_for_list_of_storage_servers e Query_for_list_of_profiles si trovano in src/bin/psql/tab-complete.c. Confrontale con Query_for_list_of_servers, che usa già la forma PG16 con un singolo LIKE '%s'. Converti le quattro nella stessa forma, ricompila psql e verifica che TAB dopo ALTER TAG t_ o ALTER STORAGE SERVER s_ completi i nomi senza alcun ERROR del coordinator. Le regole correlate per COMMENT e DROP STORAGE SERVER sono separate e possono essere gestite qui o in #2312.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Apache Cloudberry version
main
What happened
psql tab completion of object names does not work for four Cloudberry-specific object types: storage servers, tags, profiles and resource groups. Pressing TAB after ALTER STORAGE SERVER , ALTER TAG , DROP TAG , ALTER PROFILE , ALTER RESOURCE GROUP , etc. offers nothing, even when matching objects exist. Each attempt also logs a server-side ERROR on the coordinator.
Root cause. These four query macros in src/bin/psql/tab-complete.c still use the pre-PG15 template form:
Query_for_list_of_tags ... WHERE substring(pg_catalog.quote_ident(tagname),1,%d)='%s'
Query_for_list_of_resgroups ... WHERE substring(pg_catalog.quote_ident(rsgname),1,%d)='%s'
Query_for_list_of_storage_servers ... WHERE substring(pg_catalog.quote_ident(srvname),1,%d)='%s'
Query_for_list_of_profiles ... WHERE substring(pg_catalog.quote_ident(profilename),1,%d)='%s'
Upstream commit 02b8048ba5d ("psql: improve tab-complete's handling of variant SQL names", PG15) changed the template contract. _complete_from_query() now does
appendPQExpBuffer(&query_buffer, simple_query, e_object_like, e_ref_object, e_ref_schema);
and expects a single LIKE '%s'. Upstream's own macros were converted when the PG16 code was merged, but these Cloudberry-specific ones were not. As a result, %d receives a char * (undefined behavior) and %s receives the NULL e_ref_object. The generated query looks like this:
ERROR: negative substring length not allowed
STATEMENT: SELECT pg_catalog.quote_ident(srvname) FROM pg_catalog.gp_storage_server
WHERE substring(pg_catalog.quote_ident(srvname),1,-1478678816)='(null)'
When the garbage length happens to be positive, the query runs but matches nothing.
What you think should happen instead
Object names should complete. Convert the four macros to the PG16 form, as Query_for_list_of_servers already does:
#define Query_for_list_of_storage_servers \
" SELECT srvname "\
" FROM pg_catalog.gp_storage_server "\
" WHERE srvname LIKE '%s'"
The other three need the same change. The storage-server conversion has been verified: with psql rebuilt and driven through a pty, ALTER STORAGE SERVER <TAB> lists the servers, and the coordinator ERROR disappears.
How to reproduce
CREATE TAG t_demo;
CREATE PROFILE p_demo;
CREATE STORAGE SERVER s_demo OPTIONS (endpoint 'x');
In interactive psql, press TAB after each of the following. None of them completes:
ALTER TAG t_ALTER PROFILE p_ALTER STORAGE SERVER s_ALTER RESOURCE GROUP admin_
The coordinator log gets one bad query per completion attempt, against gp_storage_server, pg_tag, pg_profile and pg_resgroup, all of the substring(...,1,<garbage>)='(null)' form.
Related completion bugs for storage servers (same area)
The single-word {"SERVER", Query_for_list_of_servers} entry in words_after_create, and the generic COMMENT ON X Y → IS rule, win over the multi-word "STORAGE SERVER". This gives:
DROP STORAGE SERVER <TAB>andCREATE STORAGE USER MAPPING FOR u STORAGE SERVER <TAB>complete foreign servers (for examplegp_exttable_server).COMMENT ON STORAGE SERVER <TAB>completesISinstead of a server name.ALTER STORAGE SERVER s <TAB>offersRENAME TO, but the grammar has no such form.
The following additions were verified to fix the first three cases (the user-mapping case still needs its own rule):
else if (Matches("COMMENT", "ON", "STORAGE", "SERVER"))
COMPLETE_WITH_QUERY(Query_for_list_of_storage_servers);
...
else if (Matches("DROP", "STORAGE", "SERVER") ||
Matches("DROP", "STORAGE", "SERVER", "IF", "EXISTS"))
COMPLETE_WITH_QUERY(Query_for_list_of_storage_servers);
Operating System
Linux (platform independent)
Anything else
Found while reviewing #2312. That PR touches the ALTER STORAGE SERVER <name> completion line but not the issues above. The storage-server part can be fixed there or here.
- Lingua principale
- C
- Stelle
- 1.4k
- Fork
- 273
- Merge medio
- 4g 6h
- PR unite (30g)
- 105
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di apache/cloudberry
-
isolation2 lockmodes fails on cassert builds: extra AccessShareLock on partition rootForse già presa @tuhaihe l’ha presa oggi. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
apache/cloudberry#2356 ·
I maintainer di solito rispondono entro 2 giorni
-
[Bug] Expand fails to recognize user-defined tablespacesForse già presa @nix-oss l’ha presa 92 giorni fa. Apertatype: Bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
apache/cloudberry#1885 · 2 reazioni ·
I maintainer di solito rispondono entro 2 giorni
-
gpexpand first stage fails: 'SyncPackages' object has no attribute 'ret' (extension sync never runs; regression)Forse già presa @talmacschen-arch l’ha presa 153 giorni fa. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 86/100
apache/cloudberry#1825 ·
I maintainer di solito rispondono entro 2 giorni
-
type: Bug
Difficoltà 4/5 3-5 giorni Idoneità per principianti 53/100
apache/cloudberry#2350 · 1 reazione ·
I maintainer di solito rispondono entro 2 giorni
-
Difficoltà 5/5 Più di una settimana Idoneità per principianti 15/100
apache/cloudberry#2348 · 1 commento ·
I maintainer di solito rispondono entro 2 giorni
Tutte le issue di apache/cloudberry
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
I maintainer di solito rispondono entro 1 giorno
-
windows-artifacts: the win-arm64 job uses a Visual Studio generator missing from windows-11-armAperta
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 86/100
-
Add Royalty funding badgeAperta
Difficoltà 1/5 1-3 ore Idoneità per principianti 78/100
crosspoint-reader/crosspoint-reader#4535 ·
I maintainer di solito rispondono entro 1 giorno
-
[core] Clients never advertise RNS_UD_CS_SUPPORT_ERRINFO_PDU, so a conforming server can't send them Set Error InfoForse già presa @akallabeth l’ha presa oggi. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
FreeRDP/FreeRDP#14230 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Wrong release linkedAperta
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 88/100
Genymobile/scrcpy#7178 ·
I maintainer di solito rispondono entro 3 giorni