[Bug] Correct classification of plan nodes

Aberta
#2,268 1 comentário 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 2 dias

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
2/5
Tempo estimado
1-3 horas
Facilidade para iniciantes
58/100
Tipo de issue
Bug
Clareza
Razoavelmente clara
Status de atividade
Ativa
Stack de tecnologia
c, postgresql
Domínio
backend, databases

Direção de pesquisa

Read is_plan_node in src/backend/cdb/cdbllize.c and inspect the node definitions in plannodes.h that determine the T_Plan_Start..T_Plan_End range. Check whether the range and the listed exceptions classify plan nodes correctly, then add or update focused tests for serialization classification. Done means non-plan nodes are excluded and actual plan nodes are recognized.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

type: Bug
Apache Cloudberry version

main

What happened

Some nodes that are not plan nodes have been incorrectly categorized as plan nodes, while some actual plan nodes have failed to be classified as such. We need to categorize these nodes correctly; otherwise, it could lead to issues regarding the correctness of serialization. What follows may not be exhaustive.

diff --git a/src/backend/cdb/cdbllize.c b/src/backend/cdb/cdbllize.c
index 31749f0305b..b4bdf5bf863 100644
--- a/src/backend/cdb/cdbllize.c
+++ b/src/backend/cdb/cdbllize.c
@@ -1430,6 +1430,24 @@ is_plan_node(Node *node)
 	if (node == NULL)
 		return false;
 
+	/*
+	 * Node tags are generated in the order the structs appear in
+	 * plannodes.h, so the T_Plan_Start..T_Plan_End range is not exact:
+	 * NestLoopParam and ExternalScanInfo are defined among the plan nodes
+	 * but are not Plans, and PartitionSelector is defined after
+	 * PlanRowMark but is one.
+	 */
+	switch (nodeTag(node))
+	{
+		case T_NestLoopParam:
+		case T_ExternalScanInfo:
+			return false;
+		case T_PartitionSelector:
+			return true;
+		default:
+			break;
+	}
+
 	if (nodeTag(node) >= T_Plan_Start && nodeTag(node) < T_Plan_End)
 		return true;
 	return false;
What you think should happen instead

No response

How to reproduce

Cannot be exhaustively listed

Operating System

NAME="Rocky Linux" VERSION="9.5 (Blue Onyx)"

Anything else

No response

Are you willing to submit PR?
  • Yes, I am willing to submit a PR!
Code of Conduct
Linguagem predominante
C
Estrelas
1.4k
Forks
273
Merge médio
4d 6h
PRs com merge (30d)
105

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de apache/cloudberry

Todas as issues de apache/cloudberry

Issues semelhantes

Mais issues de C

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.