Extraction of MessageQueue full via variable Bug in msg getting duplicated.
Ninguém assumiu esta issue ainda.
Avaliação
- Dificuldade
- 4/5
- Tempo estimado
- 3-5 dias
- Facilidade para iniciantes
- 35/100
- Tipo de issue
- Bug
- Clareza
- Razoavelmente clara
- Status de atividade
- Estagnada
- Domínio
- networking, robotics
Direção de pesquisa
Start with ROSConnection and the outgoingQueue loop that calls OutgoingMessageSender.SendInternal, then reproduce the message drops and duplication described under Docker and Linux. Trace the Normal and QueueFullWarning states and compare the observed behavior with the reported queue-full flag workaround. Done means the queue condition and delivery behavior are understood and the issue's loss or duplication is resolved without requiring the workaround.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
Is your feature request related to a problem? Please describe.
Right now it seems that when messages are too large at some point messages get dropped however only a Debug msg ("Queue full! Messages are getting dropped!) gets displayed.
Additionally it seems that message get published then sometimes multiple times instead of just once even so the publish function was not called multiple times
This is a kinda critical bug as it will effect algorithms working with the data
Having a flag which can be check to then pause simulation/ publishing untill all message got delivered would be helpfulable.
I implemented that feature as show below.
I additionally have a subscriber on the rosside now to check that all message got delivered, then publishes a msg which gets received on unity side and only then let simulation continue,
as otherwise i always lost data at some point.
This issue seems to happen when i use it with a docker as the ros side, however under linux the issue of duplicating message also presist but i didnt observe message drops.
Describe the solution you'd like
I implement that feature in the following way i added to ROSConnection
[SerializeField]
static bool m_queuefull=false;
public bool queuefull { get => m_queuefull; set => m_queuefull = value; }
public bool Queue(){
return queuefull;
}
furthermore at the line
int count=0;
while (outgoingQueue.TryDequeue(out OutgoingMessageSender sendsOutgoingMessages))
{
OutgoingMessageSender.SendToState sendToState = sendsOutgoingMessages.SendInternal(messageSerializer, networkStream);
switch (sendToState)
{
case OutgoingMessageSender.SendToState.Normal:
//This is normal operation.
count=count+1;
//this must always be +1 one than your queue size otherwise the stuff gets stuck
//queue size should always be at least 1 larger than the amount of message you have in one go.
if(count >=4){
ROSConnection.m_queuefull=true;
}
Debug.Log("called"+count);
break;
case OutgoingMessageSender.SendToState.QueueFullWarning:
//Unable to send messages to ROS as fast as we're generating them.
//This could be caused by a TCP connection that is too slow.
Debug.LogWarning($"Queue full! Messages are getting dropped! " +
"Try check your connection speed is fast enough to handle the traffic."+count);
ROSConnection.m_queuefull=true;
break;
case OutgoingMessageSender.SendToState.NoMessageToSendError:
//This indicates
Debug.LogError(
"Logic Error! A 'SendsOutgoingMessages' was queued but did not have any messages to send.");
break;
}
token.ThrowIfCancellationRequested();
waitingSinceRealTime = s_RealTimeSinceStartup;
}
ROSConnection.m_queuefull=false;
By this we can read out if the msg queue is full in any program for example via:
ros = ROSConnection.GetOrCreateInstance();
bool rosqueuefull =ros.Queue();
Describe alternatives you've considered
Additional context
Add any other context or screenshots about the feature request here.
- Linguagem predominante
- C#
- Estrelas
- 2.6k
- Forks
- 473
- Métricas de merge de PRs
- Nenhum PR com merge em 30d
Preparar o ambiente
- Sem Dockerfile nem arquivo Docker Compose
- Tem um modelo de pull request
- Sem guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de Unity-Technologies/Unity-Robotics-Hub
-
Dificuldade 3/5 1-2 dias Facilidade para iniciantes 35/100
-
ROS2,ActionAberta
Dificuldade 4/5 3-5 dias Facilidade para iniciantes 25/100
-
Is the project deprecated?Aberta
Dificuldade 1/5 Menos de uma hora Facilidade para iniciantes 20/100
-
Force/Torque sensorAberta
Dificuldade 5/5 Mais de uma semana Facilidade para iniciantes 15/100
-
Dificuldade 4/5 3-5 dias Facilidade para iniciantes 25/100
Unity-Technologies/Unity-Robotics-Hub#433 · 1 comentário ·
Todas as issues de Unity-Technologies/Unity-Robotics-Hub
Issues semelhantes
-
DXF with empty names failsAbertabug
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 72/100
Mantenedores costumam responder em até 3 dias
-
bug python
Dificuldade 1/5 Menos de uma hora Facilidade para iniciantes 88/100
ilia-sokolov/OfficeAgent.NET#89 ·
Mantenedores costumam responder em até 13 dias
-
documentation
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 82/100
juandresrodca/AdminForge#66 ·
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 70/100
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 72/100
umbraco/Umbraco.Automate#612 ·
Mantenedores costumam responder em até 1 dia