useDeferredValue with an object created during render hangs the page after any re-render (0.3.0)

Aberta
#153 1 comentário 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
57/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
react, typescript, vite
Domínio
frontend

Direção de pesquisa

Start by tracing v() in packages/redact/src/dom/transitions.ts, then follow how enqueue, scheduleUpdate, flushRoot, renderUpdates, and flushTransitions handle the fiber. Reproduce with the supplied React component and Vite build, with and without redact(). Done when the page stays responsive after the post-mount re-render and a regression check covers this case.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Summary

Passing an object created during render to useDeferredValue hangs the tab as soon as the component re-renders after mount. React settles after 3 renders. Redact renders forever and keeps throwing from the flushPending guard, so the main thread stays busy and the page stops responding.

React's docs warn that this pattern causes an unnecessary background render. It is wasteful there, but it finishes.

Reproduction

No router, Suspense, compiler or hydration is involved.

import { useDeferredValue, useEffect, useState } from 'react'
import { createRoot } from 'react-dom/client'

window.renders = 0

function App() {
  window.renders++
  const [, setTick] = useState(0)
  useDeferredValue({})
  useEffect(() => setTick(1), [])
  return <p>done</p>
}

createRoot(document.getElementById('root')).render(<App />)

Build with vite build with and without the redact() plugin, then open the page.

Runtime Renders after about 3 s Page errors Page
React 19.3.1 3 0 Responsive
Redact 0.3.0 3,873,811 44,178 Unresponsive

These are unminified production builds, so the errors are the bare Error() from flushPending. The count is what had accumulated when I paused the page in the debugger.

The first render does not loop. It takes any re-render after mount, and in my tests a setState in an effect, a setState in a layout effect and a useSyncExternalStore update all triggered it.

Possible cause

This comes from reading the source. I have not tested a patch.

In v() in packages/redact/src/dom/transitions.ts, a normal render whose value differs from hook.s calls enqueue(fiber), which also calls scheduleUpdate(fiber). flushRoot then runs renderUpdates followed by flushTransitions. The transition pass accepts the value, but the fiber still seems to be queued for a normal pass. That pass creates another new object, which differs from hook.s, so it enqueues again.

Real-world impact

I hit this in a TanStack Start app where a hook returned a new query options object on every render, with a stable query key, and the result went to useDeferredValue. The page froze on load under Redact and works under React.

Memoizing the value avoids the loop.

Environment
  • @tanstack/redact 0.3.0 (also 0.2.5), default redact() preset
  • React 19.3.1 (control)
  • Vite 7.3.7, @vitejs/plugin-react 5.2.0
  • Chromium 156 (Playwright), Node 26
Linguagem predominante
TypeScript
Estrelas
581
Forks
28
Merge médio
13h 48min
PRs com merge (30d)
45

Preparar o ambiente

Este projeto não oferece contêiner de desenvolvimento, Dockerfile nem guia de contribuição, então a configuração fica por sua conta: comece pelo README e veja nosso guia da primeira contribuição para os passos gerais.

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de TanStack/redact

Todas as issues de TanStack/redact

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.