useDeferredValue with an object created during render hangs the page after any re-render (0.3.0)

Abierto
#153 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
57/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
react, typescript, vite
Área
frontend

Línea de trabajo

Start by tracing v() in packages/redact/src/dom/transitions.ts, then follow how enqueue, scheduleUpdate, flushRoot, renderUpdates, and flushTransitions handle the fiber. Reproduce with the supplied React component and Vite build, with and without redact(). Done when the page stays responsive after the post-mount re-render and a regression check covers this case.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Summary

Passing an object created during render to useDeferredValue hangs the tab as soon as the component re-renders after mount. React settles after 3 renders. Redact renders forever and keeps throwing from the flushPending guard, so the main thread stays busy and the page stops responding.

React's docs warn that this pattern causes an unnecessary background render. It is wasteful there, but it finishes.

Reproduction

No router, Suspense, compiler or hydration is involved.

import { useDeferredValue, useEffect, useState } from 'react'
import { createRoot } from 'react-dom/client'

window.renders = 0

function App() {
  window.renders++
  const [, setTick] = useState(0)
  useDeferredValue({})
  useEffect(() => setTick(1), [])
  return <p>done</p>
}

createRoot(document.getElementById('root')).render(<App />)

Build with vite build with and without the redact() plugin, then open the page.

Runtime Renders after about 3 s Page errors Page
React 19.3.1 3 0 Responsive
Redact 0.3.0 3,873,811 44,178 Unresponsive

These are unminified production builds, so the errors are the bare Error() from flushPending. The count is what had accumulated when I paused the page in the debugger.

The first render does not loop. It takes any re-render after mount, and in my tests a setState in an effect, a setState in a layout effect and a useSyncExternalStore update all triggered it.

Possible cause

This comes from reading the source. I have not tested a patch.

In v() in packages/redact/src/dom/transitions.ts, a normal render whose value differs from hook.s calls enqueue(fiber), which also calls scheduleUpdate(fiber). flushRoot then runs renderUpdates followed by flushTransitions. The transition pass accepts the value, but the fiber still seems to be queued for a normal pass. That pass creates another new object, which differs from hook.s, so it enqueues again.

Real-world impact

I hit this in a TanStack Start app where a hook returned a new query options object on every render, with a stable query key, and the result went to useDeferredValue. The page froze on load under Redact and works under React.

Memoizing the value avoids the loop.

Environment
  • @tanstack/redact 0.3.0 (also 0.2.5), default redact() preset
  • React 19.3.1 (control)
  • Vite 7.3.7, @vitejs/plugin-react 5.2.0
  • Chromium 156 (Playwright), Node 26
Lenguaje dominante
TypeScript
Estrellas
581
Forks
28
Merge medio
13 h 48 min
PR fusionados (30 d)
45

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de TanStack/redact

Todos los issues de TanStack/redact

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.