Carry hosted stale-install and takeover warnings as RunWarning, not serde_json::Value round-tripped through run_warning_of

Aberta
  • Algo errado?
#1,879 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
66/100
Tipo de issue
Refatoração
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
rust
Domínio
cli

Direção de pesquisa

Read scan/hosted.rs first, especially run_warning_of and run_redirect_selected_untracked, then trace the warning fields and constructors in scan/hosted/python.rs, scan/hosted/nuget.rs, scan/hosted/takeover.rs, and vlt_heal.rs. Convert these paths to carry RunWarning, mapping RewriteWarning once. Run the named hosted and redirect end to end suites; done when their human and JSON warning output is unchanged and no listed file contains a json! warning literal.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

agent:triaged arch-audit priority:p3 refactor

[agent] Filed by the scheduled architecture audit (audit-cli-tests). Register: register comment.

Kind: refactor. Register ID: T27 (part of T21, the warning sink).

Problem

Several hosted helpers build their warnings as untyped serde_json::json!({"code": .., "detail": ..}) values:

  • the gem probe: scan/hosted.rs L300, L309;
  • scan/hosted/python.rs L201;``
  • scan/hosted/nuget.rs L75;````
  • vlt_heal.rs L373, L417;
  • scan/hosted/takeover.rs L161, L238, L286, L382, L492, L609, L623. takeover even converts typed core RewriteWarnings into JSON values.

The caller then parses them back with run_warning_of, scan/hosted.rs L162-L167:`````

RunWarning::new(
    w["code"].as_str().unwrap_or_default(),
    w["detail"].as_str().unwrap_or_default(),
)

A typo in a key silently becomes an empty code. The fold in run_redirect_selected_untracked (hosted.rs L1863-L1898) juggles four warning shapes at once: RewriteWarning, Value, the go audit's (String, String), and RunWarning.

Proposed change

  • Make StaleInstallOutcome.warnings and takeover::Finished.warnings (and the vlt heal outcome) a Vec<RunWarning>.
  • Build those warnings with RunWarning::new at each site.
  • Map RewriteWarning → RunWarning once with a From impl.
  • Delete run_warning_of.

Size

5 files (scan/hosted.rs, scan/hosted/{python,nuget,takeover}.rs, vlt_heal.rs). Roughly −40 / +20.

Acceptance criteria

  • --json warnings[] and the human output are unchanged. The e2e hosted suites (e2e_hosted_production.rs, e2e_redirect_*) guard them.
  • No json!({"code" warning literal remains in these files.
Linguagem predominante
Rust
Estrelas
9
Forks
2
Merge médio
18h 47min
PRs com merge (30d)
637

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de SocketDev/socket-patch

Todas as issues de SocketDev/socket-patch

Issues semelhantes

Mais issues de Rust

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.