Carry hosted stale-install and takeover warnings as RunWarning, not serde_json::Value round-tripped through run_warning_of

Abierto
  • ¿Algo no está bien?
#1,879 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
66/100
Tipo de issue
Refactorización
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
rust
Área
cli

Línea de trabajo

Read scan/hosted.rs first, especially run_warning_of and run_redirect_selected_untracked, then trace the warning fields and constructors in scan/hosted/python.rs, scan/hosted/nuget.rs, scan/hosted/takeover.rs, and vlt_heal.rs. Convert these paths to carry RunWarning, mapping RewriteWarning once. Run the named hosted and redirect end to end suites; done when their human and JSON warning output is unchanged and no listed file contains a json! warning literal.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

agent:triaged arch-audit priority:p3 refactor

[agent] Filed by the scheduled architecture audit (audit-cli-tests). Register: register comment.

Kind: refactor. Register ID: T27 (part of T21, the warning sink).

Problem

Several hosted helpers build their warnings as untyped serde_json::json!({"code": .., "detail": ..}) values:

  • the gem probe: scan/hosted.rs L300, L309;
  • scan/hosted/python.rs L201;``
  • scan/hosted/nuget.rs L75;````
  • vlt_heal.rs L373, L417;
  • scan/hosted/takeover.rs L161, L238, L286, L382, L492, L609, L623. takeover even converts typed core RewriteWarnings into JSON values.

The caller then parses them back with run_warning_of, scan/hosted.rs L162-L167:`````

RunWarning::new(
    w["code"].as_str().unwrap_or_default(),
    w["detail"].as_str().unwrap_or_default(),
)

A typo in a key silently becomes an empty code. The fold in run_redirect_selected_untracked (hosted.rs L1863-L1898) juggles four warning shapes at once: RewriteWarning, Value, the go audit's (String, String), and RunWarning.

Proposed change

  • Make StaleInstallOutcome.warnings and takeover::Finished.warnings (and the vlt heal outcome) a Vec<RunWarning>.
  • Build those warnings with RunWarning::new at each site.
  • Map RewriteWarning → RunWarning once with a From impl.
  • Delete run_warning_of.

Size

5 files (scan/hosted.rs, scan/hosted/{python,nuget,takeover}.rs, vlt_heal.rs). Roughly −40 / +20.

Acceptance criteria

  • --json warnings[] and the human output are unchanged. The e2e hosted suites (e2e_hosted_production.rs, e2e_redirect_*) guard them.
  • No json!({"code" warning literal remains in these files.
Lenguaje dominante
Rust
Estrellas
9
Forks
2
Merge medio
20 h 47 min
PR fusionados (30 d)
681

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de SocketDev/socket-patch

Todos los issues de SocketDev/socket-patch

Issues similares

Más issues de Rust

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.