Evaluators price scripts at a fixed protocol version

Aberta
  • Algo errado?
#697 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
48/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
typescript
Domínio
backend-api-design

Direção de pesquisa

Start at packages/evolution/src/sdk/builders/TransactionBuilder.ts:146 and trace how provider protocol parameters reach EvaluationContext; the issue says the major version is currently dropped. Check the Ogmios, Koios, and Blockfrost version fields, then inspect the uplc and Scalus evaluator entry points named in the issue. Done when both evaluators use the network's protocol version and their costs match the node for versions 10 and 11.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

bug

The local evaluators price scripts with the rules of one fixed protocol version, whatever version the network runs. The ledger picks the builtin cost rules by protocol version. From version 11, divideInteger and modInteger cost more when the dividend is narrower than the divisor. In Plutus V1 and V2 the memory of modInteger and remainderInteger changes too (plutus-ledger-api/src/PlutusLedgerApi/V2/EvaluationContext.hs:58-63 and V3/EvaluationContext.hs:51-57 at Plutus 1.72.0.0).

  • aiken-uplc builds on uplc 1.1.21 (packages/aiken-uplc/rust/Cargo.toml:10), which has only the rules from before version 11. Mainnet, preprod and preview are at 11, so a script that divides by an operand wider than 64 bits is under-declared. Compared with the mainnet node, V2 divideInteger(7, 10^300) costs 309,948 steps in aiken-uplc and 454,517 on the node.
  • scalus-uplc after #615 always uses version 11. That is right for the public networks, but the default devnet starts at 10. There, V2 modInteger with a wide dividend comes out at 1,501 memory against the node's 1,515.

In both cases the node rejects the transaction at submission with "Invalid transaction submitted as valid" (Ogmios code 3136). The transaction never enters the mempool, so no collateral is taken.

The fix is to carry the protocol major version in EvaluationContext (packages/evolution/src/sdk/builders/TransactionBuilder.ts:146), filled from the provider's protocol parameters. Ogmios returns it as version.major, Koios as protocol_major and Blockfrost as protocol_major_ver, but ProtocolParameters drops it today. Both evaluators can take it: uplc 1.1.23 and later through eval_phase_two_raw_with_protocol, and Scalus through evaluateTx. Bumping uplc to 1.1.24 without passing the version would move the mismatch to version 10 networks, as it did for Scalus.

Linguagem predominante
TypeScript
Estrelas
22
Forks
33
Merge médio
21h 38min
PRs com merge (30d)
55

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de IntersectMBO/evolution-sdk

Todas as issues de IntersectMBO/evolution-sdk

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.