Evaluators price scripts at a fixed protocol version

Ouverte
  • Quelque chose ne va pas ?
#697 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
48/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
typescript
Domaine
backend-api-design

Piste de recherche

Start at packages/evolution/src/sdk/builders/TransactionBuilder.ts:146 and trace how provider protocol parameters reach EvaluationContext; the issue says the major version is currently dropped. Check the Ogmios, Koios, and Blockfrost version fields, then inspect the uplc and Scalus evaluator entry points named in the issue. Done when both evaluators use the network's protocol version and their costs match the node for versions 10 and 11.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

bug

The local evaluators price scripts with the rules of one fixed protocol version, whatever version the network runs. The ledger picks the builtin cost rules by protocol version. From version 11, divideInteger and modInteger cost more when the dividend is narrower than the divisor. In Plutus V1 and V2 the memory of modInteger and remainderInteger changes too (plutus-ledger-api/src/PlutusLedgerApi/V2/EvaluationContext.hs:58-63 and V3/EvaluationContext.hs:51-57 at Plutus 1.72.0.0).

  • aiken-uplc builds on uplc 1.1.21 (packages/aiken-uplc/rust/Cargo.toml:10), which has only the rules from before version 11. Mainnet, preprod and preview are at 11, so a script that divides by an operand wider than 64 bits is under-declared. Compared with the mainnet node, V2 divideInteger(7, 10^300) costs 309,948 steps in aiken-uplc and 454,517 on the node.
  • scalus-uplc after #615 always uses version 11. That is right for the public networks, but the default devnet starts at 10. There, V2 modInteger with a wide dividend comes out at 1,501 memory against the node's 1,515.

In both cases the node rejects the transaction at submission with "Invalid transaction submitted as valid" (Ogmios code 3136). The transaction never enters the mempool, so no collateral is taken.

The fix is to carry the protocol major version in EvaluationContext (packages/evolution/src/sdk/builders/TransactionBuilder.ts:146), filled from the provider's protocol parameters. Ogmios returns it as version.major, Koios as protocol_major and Blockfrost as protocol_major_ver, but ProtocolParameters drops it today. Both evaluators can take it: uplc 1.1.23 and later through eval_phase_two_raw_with_protocol, and Scalus through evaluateTx. Bumping uplc to 1.1.24 without passing the version would move the mismatch to version 10 networks, as it did for Scalus.

Langage dominant
TypeScript
Étoiles
22
Forks
33
Merge moyen
21 h 38 min
PR mergées (30 j)
55

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de IntersectMBO/evolution-sdk

Toutes les issues de IntersectMBO/evolution-sdk

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.