buf_from_list of a non-list answers null in every state of EIGS_STRICT

Aberta
#2,467 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
58/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
c
Domínio
backend

Direção de pesquisa

Start with the buf_from_list builtin implementation and the strict type guard pattern used by similar builtins; then read tools/strict_differential.sh, tests/strict_guard_release_messages.tsv, and the buf_* constructor probes. Run the strict differential checks in the default and both strict modes. Done means wrong-typed inputs raise type_mismatch under EIGS_STRICT=1 without setting a variable, preserve current behavior under EIGS_STRICT=0, and the builtin documentation describes non-list behavior.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

area:stdlib kind:silent-wrong

buf_from_list given something that is not a list answers null, in every state of EIGS_STRICT, where a wrong-typed argument of a builtin raises by default (#2439):

$ cat p.eigs
try:
    x is buf_from_list of 1
    print of [x, type of x]
catch e:
    print of [e.kind, e.message]
try:
    y is buf_from_list of "a"
    print of [y, type of y]
catch e:
    print of [e.kind, e.message]
$ eigenscript p.eigs                 # phase2-numbers at f9f3e49b; the same with EIGS_STRICT=0 and EIGS_STRICT=1
[null, "null"]
[null, "null"]

The last release (v0.48.0) answers null too, so this is not from the branch: the builtin has never had a guard, and it is not among the guard probes of tools/strict_differential.sh (no row for it in tests/strict_guard_release_messages.tsv).

It is easy to reach by accident: brackets after of are an argument list, so buf_from_list of [1] passes the number 1, not a list of one. A program that writes it gets a null buffer and fails later, somewhere else.

Found beside a reading of the documents against the runtime (#1776); not one of that reading's findings.

Done when

  • buf_from_list of a value that is not a list (a number, a string, null, a dict) raises type_mismatch with no variable set and under EIGS_STRICT=1, with a message that names the builtin; under EIGS_STRICT=0 it keeps today's answer.
  • The builtin has a guard probe in tools/strict_differential.sh, in the default mode and the two others, and its row in tests/strict_guard_release_messages.tsv, or the row's absence is explained there (the release does not raise, so the release is not its oracle).
  • The other buf_* constructors that take a list or a size are probed the same way once, and each that answers quietly for a wrong type is listed on this issue (fixed here or filed).
  • docs/BUILTINS.md's row for buf_from_list says what a non-list gives.

— Claude DevBox

Linguagem predominante
C
Estrelas
3
Forks
7
Merge médio
3h 28min
PRs com merge (30d)
270

Preparar o ambiente

Abrir no Codespaces

Inicia o contêiner de desenvolvimento do projeto no navegador, com a sua própria conta do GitHub.

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de InauguralSystems/EigenScript

Todas as issues de InauguralSystems/EigenScript

Issues semelhantes

Mais issues de C

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.