buf_from_list of a non-list answers null in every state of EIGS_STRICT

Abierto
#2,467 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
58/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
c
Área
backend

Línea de trabajo

Start with the buf_from_list builtin implementation and the strict type guard pattern used by similar builtins; then read tools/strict_differential.sh, tests/strict_guard_release_messages.tsv, and the buf_* constructor probes. Run the strict differential checks in the default and both strict modes. Done means wrong-typed inputs raise type_mismatch under EIGS_STRICT=1 without setting a variable, preserve current behavior under EIGS_STRICT=0, and the builtin documentation describes non-list behavior.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area:stdlib kind:silent-wrong

buf_from_list given something that is not a list answers null, in every state of EIGS_STRICT, where a wrong-typed argument of a builtin raises by default (#2439):

$ cat p.eigs
try:
    x is buf_from_list of 1
    print of [x, type of x]
catch e:
    print of [e.kind, e.message]
try:
    y is buf_from_list of "a"
    print of [y, type of y]
catch e:
    print of [e.kind, e.message]
$ eigenscript p.eigs                 # phase2-numbers at f9f3e49b; the same with EIGS_STRICT=0 and EIGS_STRICT=1
[null, "null"]
[null, "null"]

The last release (v0.48.0) answers null too, so this is not from the branch: the builtin has never had a guard, and it is not among the guard probes of tools/strict_differential.sh (no row for it in tests/strict_guard_release_messages.tsv).

It is easy to reach by accident: brackets after of are an argument list, so buf_from_list of [1] passes the number 1, not a list of one. A program that writes it gets a null buffer and fails later, somewhere else.

Found beside a reading of the documents against the runtime (#1776); not one of that reading's findings.

Done when

  • buf_from_list of a value that is not a list (a number, a string, null, a dict) raises type_mismatch with no variable set and under EIGS_STRICT=1, with a message that names the builtin; under EIGS_STRICT=0 it keeps today's answer.
  • The builtin has a guard probe in tools/strict_differential.sh, in the default mode and the two others, and its row in tests/strict_guard_release_messages.tsv, or the row's absence is explained there (the release does not raise, so the release is not its oracle).
  • The other buf_* constructors that take a list or a size are probed the same way once, and each that answers quietly for a wrong type is listed on this issue (fixed here or filed).
  • docs/BUILTINS.md's row for buf_from_list says what a non-list gives.

— Claude DevBox

Lenguaje dominante
C
Estrellas
3
Forks
7
Merge medio
3 h 28 min
PR fusionados (30 d)
270

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de InauguralSystems/EigenScript

Todos los issues de InauguralSystems/EigenScript

Issues similares

Más issues de C

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.