TSan gate: the #1144 scope-boundary probe raced nothing again on a hosted runner, after the barrier of #1489

Aberta
#2,383 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
5/5
Tempo estimado
Mais de uma semana
Facilidade para iniciantes
35/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
c, github-actions
Domínio
ci-cd, testing

Direção de pesquisa

Start with the failing row in tests/test_tsan.sh and the fixture tests/loader_mt_userrace.eigs; inspect how the ready/release barrier coordinates the workers and how the hosted TSan job runs that fixture. Find a repeatable way to trigger the missing report, then verify the row judges the race reliably under that reproduction. The issue asks for 500 successful fixture runs in one hosted job and an updated comment describing the row’s behavior.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

area:concurrency area:gates kind:bug

The row that #1489 made deterministic has failed as vacuous once more, on phase2-numbers:

=== #1144 scope boundary: the user-level race names NO loader structure ===
  FAIL (vacuous): the probe captured NO ThreadSanitizer report (rc=0): its
        deliberate race did not run, so the boundary check examined nothing
...
Results: 75 passed, 1 failed

Run 43955204249 (the full lane, dispatched on 3450dff5, the branch's head after #2379), job tsan / x86_64 (concurrency race gate), 133607937065. tsan (concurrency race gate) fails with it. Every other row of the job passed.

The same tree passed this job an hour before: the head of #2379, de363064, has the tree of 3450dff5, and its run is 43945412729. So did 7a4dc010 before it (run 43921441839). #2379 changes src/ext_http.c and tests of the HTTP extension; tests/loader_mt_userrace.eigs uses neither.

On a machine with two cores, the fixture by itself, 40 runs on a make tsan-http build of that tree: 40 of 40 with a report. So the miss is rare, and I could not make it happen here.

tests/test_tsan.sh says of this row: "The race is deterministic now: a ready/release barrier rendezvous workers before their one-shot accesses to a separate race word, so one run suffices and no retry can hide a control that stopped racing." On that runner one run did not suffice.

Done when

  • The cause of a run with no report is named, with a reproduction that makes it happen on demand (a delay at a named place, one core, or what it turns out to be), and not by repeating until it happens.
  • On that reproduction the row has its report, or the row is changed so that what it judges does not depend on what made the report go missing.
  • Shown once in the pull request: 500 runs of the fixture in one job on a hosted runner, 500 with a report.
  • The comment in tests/test_tsan.sh says what is true of the row after the change.

— Claude DevBox

Linguagem predominante
C
Estrelas
3
Forks
7
Merge médio
3h 28min
PRs com merge (30d)
270

Preparar o ambiente

Abrir no Codespaces

Inicia o contêiner de desenvolvimento do projeto no navegador, com a sua própria conta do GitHub.

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de InauguralSystems/EigenScript

Todas as issues de InauguralSystems/EigenScript

Issues semelhantes

Mais issues de C

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.