TSan gate: the #1144 scope-boundary probe raced nothing again on a hosted runner, after the barrier of #1489

Abierto
#2,383 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
c, github-actions
Área
ci-cd, testing

Línea de trabajo

Start with the failing row in tests/test_tsan.sh and the fixture tests/loader_mt_userrace.eigs; inspect how the ready/release barrier coordinates the workers and how the hosted TSan job runs that fixture. Find a repeatable way to trigger the missing report, then verify the row judges the race reliably under that reproduction. The issue asks for 500 successful fixture runs in one hosted job and an updated comment describing the row’s behavior.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area:concurrency area:gates kind:bug

The row that #1489 made deterministic has failed as vacuous once more, on phase2-numbers:

=== #1144 scope boundary: the user-level race names NO loader structure ===
  FAIL (vacuous): the probe captured NO ThreadSanitizer report (rc=0): its
        deliberate race did not run, so the boundary check examined nothing
...
Results: 75 passed, 1 failed

Run 43955204249 (the full lane, dispatched on 3450dff5, the branch's head after #2379), job tsan / x86_64 (concurrency race gate), 133607937065. tsan (concurrency race gate) fails with it. Every other row of the job passed.

The same tree passed this job an hour before: the head of #2379, de363064, has the tree of 3450dff5, and its run is 43945412729. So did 7a4dc010 before it (run 43921441839). #2379 changes src/ext_http.c and tests of the HTTP extension; tests/loader_mt_userrace.eigs uses neither.

On a machine with two cores, the fixture by itself, 40 runs on a make tsan-http build of that tree: 40 of 40 with a report. So the miss is rare, and I could not make it happen here.

tests/test_tsan.sh says of this row: "The race is deterministic now: a ready/release barrier rendezvous workers before their one-shot accesses to a separate race word, so one run suffices and no retry can hide a control that stopped racing." On that runner one run did not suffice.

Done when

  • The cause of a run with no report is named, with a reproduction that makes it happen on demand (a delay at a named place, one core, or what it turns out to be), and not by repeating until it happens.
  • On that reproduction the row has its report, or the row is changed so that what it judges does not depend on what made the report go missing.
  • Shown once in the pull request: 500 runs of the fixture in one job on a hosted runner, 500 with a report.
  • The comment in tests/test_tsan.sh says what is true of the row after the change.

— Claude DevBox

Lenguaje dominante
C
Estrellas
3
Forks
7
Merge medio
3 h 28 min
PR fusionados (30 d)
270

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de InauguralSystems/EigenScript

Todos los issues de InauguralSystems/EigenScript

Issues similares

Más issues de C

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.