Runtime-generated FSR/AFMF presents may suppress simulation intervals and report 0 Simulation FPS

Aberta
#742 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 2 dias

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
45/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
cpp
Domínio
performance

Direção de pesquisa

Start with ComputeMsBetweenSimulationStarts() and the UnifiedSwapChain state updates for lastSimStartTime; read PcLatencyFrameGenerationTests::GeneratedPresentDoesNotTakeApplicationPclData for the existing PCL behavior. Add an end-to-end test for generated/application presents sharing a timestamp, including repeated pairs and the listed regression cases. Done means marked application frames produce intervals while generated rows and missing-marker frames do not, with unit coverage and a live or PresentBench2 ETL confirmation.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Summary

Runtime frame generation using separate generated presents, such as FSR-FG or AFMF, may prevent PresentMon from producing msBetweenSimStarts samples when PCL simulation markers are enabled.

This is currently a source-supported hypothesis, not a confirmed live-hardware reproduction.

Suspected symptoms

Affected workloads may show:

  • MsBetweenSimulationStart as NA.
  • Missing PM_METRIC_BETWEEN_SIMULATION_START frame values.
  • Simulation FPS or Simulation Frame Time reporting 0 despite active rendering.
  • No valid simulation samples across repeated generated/application frame pairs.

This likely affects runtime-generated FSR/AFMF presents using PCL markers. It is not expected to affect ordinary presentation, application-provider markers, XeSS-FG's currently tested ordering, or generated displays attached to the application's own present.

Root-cause hypothesis

With FSR-style runtime frame generation:

  1. The generated present completes before its application present.
  2. Both presents receive the application's PCL simulation-start timestamp.
  3. The generated row emits no simulation interval because it is not an application frame.
  4. Despite that, it advances the swap chain's global lastSimStartTime.
  5. The application row then carries the same timestamp.
  6. ComputeMsBetweenSimulationStarts() requires currentSimStartTime > lastSimStartTime, so the application row also emits no interval.

Repeating this sequence may leave the capture with no valid simulation interval samples.

Existing test PcLatencyFrameGenerationTests::GeneratedPresentDoesNotTakeApplicationPclData confirms the prerequisite that generated and application presents can receive the same PCL timestamp.

When this behavior arose

The underlying simulation interval logic has existed since at least commit ee39f134 on January 5, 2026.

The suspected duplicate-timestamp interaction took its current form in commit 081c989b on November 18, 2026, merged through #725. That change correctly allowed a generated present to read PCL data without claiming it, so the following application present could receive the same data.

Before #725, the generated present could consume the timing entry and leave the application present without PCL data. After #725, both presents can carry the same timestamp, exposing the lastSimStartTime interaction described above.

The existing CSV and frame-query simulation interval surfaces predate #741. That PR only makes the behavior more visible by deriving Simulation FPS and Simulation Frame Time from the same field.

Validation plan

End-to-end unit test

Construct a generated AMD_FSR_FG present followed by an application present sharing one PCL simulation timestamp, and feed them through UnifiedSwapChain in their expected completion/display order.

Verify that:

  • The generated row has no simulation interval.
  • The application row should produce an interval relative to the previous application marker.
  • Repeated generated/application pairs continue producing application intervals.
  • Missing-marker application frames, dropped frames, XeSS-style ordering, and source transitions do not regress.

This test should exercise actual state updates rather than assigning lastSimStartTime manually.

PresentBench2 experiment

Extend PresentBench2 with optional real FSR-FG support:

  • Add a DX12 --use-fsr-fg mode and capability reporting.
  • Supply FSR-FG depth, motion-vector, and timing inputs.
  • Emit AMD_FSR_FG frame-type events for generated presents.
  • Run with --emit-pcl-markers.
  • Capture ETL and inspect frame type, PCL frame ID, simulation timestamps, MsBetweenSimulationStart, Simulation FPS, and Simulation Frame Time.

Compare frame generation disabled, FSR-FG enabled, and XeSS-FG enabled.

FSR-FG is cross-vendor, so AMD hardware is not inherently required. Use hardware explicitly supported by the selected FSR SDK version.

Fix proposals

Option A: Update simulation history only for application work

Prevent generated-only rows from advancing lastSimStartTime. Application frames without markers should continue leaving the previous valid marker intact.

This is the smallest fix, but all other users of lastSimStartTime must be audited.

Option B: Track application simulation history separately

Add a dedicated lastAppSimStartTime, update it only from application frames with valid markers, and use it for msBetweenSimStarts.

This avoids changing other consumers of lastSimStartTime and is likely safer, but requires coordinated V1, V2, bootstrap, dropped-frame, and reset handling.

Acceptance criteria

  • Generated rows remain missing for application simulation interval metrics.
  • Each marked application frame after initialization produces a valid interval.
  • No CPU fallback is introduced.
  • Missing markers do not erase prior valid application marker history.
  • Existing PC latency, animation, XeSS-FG, CSV, and frame-query behavior does not regress.
  • Unit coverage and a live or PresentBench2 ETL confirm the result.
Linguagem predominante
C++
Estrelas
2.6k
Forks
201
Merge médio
2d 21h
PRs com merge (30d)
16

Preparar o ambiente

Este projeto não oferece contêiner de desenvolvimento, Dockerfile nem guia de contribuição, então a configuração fica por sua conta: comece pelo README e veja nosso guia da primeira contribuição para os passos gerais.

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de GameTechDev/PresentMon

Todas as issues de GameTechDev/PresentMon

Issues semelhantes

Mais issues de C++

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.