Runtime-generated FSR/AFMF presents may suppress simulation intervals and report 0 Simulation FPS

Abierto
#742 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 2 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
45/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
cpp
Área
performance

Línea de trabajo

Start with ComputeMsBetweenSimulationStarts() and the UnifiedSwapChain state updates for lastSimStartTime; read PcLatencyFrameGenerationTests::GeneratedPresentDoesNotTakeApplicationPclData for the existing PCL behavior. Add an end-to-end test for generated/application presents sharing a timestamp, including repeated pairs and the listed regression cases. Done means marked application frames produce intervals while generated rows and missing-marker frames do not, with unit coverage and a live or PresentBench2 ETL confirmation.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Summary

Runtime frame generation using separate generated presents, such as FSR-FG or AFMF, may prevent PresentMon from producing msBetweenSimStarts samples when PCL simulation markers are enabled.

This is currently a source-supported hypothesis, not a confirmed live-hardware reproduction.

Suspected symptoms

Affected workloads may show:

  • MsBetweenSimulationStart as NA.
  • Missing PM_METRIC_BETWEEN_SIMULATION_START frame values.
  • Simulation FPS or Simulation Frame Time reporting 0 despite active rendering.
  • No valid simulation samples across repeated generated/application frame pairs.

This likely affects runtime-generated FSR/AFMF presents using PCL markers. It is not expected to affect ordinary presentation, application-provider markers, XeSS-FG's currently tested ordering, or generated displays attached to the application's own present.

Root-cause hypothesis

With FSR-style runtime frame generation:

  1. The generated present completes before its application present.
  2. Both presents receive the application's PCL simulation-start timestamp.
  3. The generated row emits no simulation interval because it is not an application frame.
  4. Despite that, it advances the swap chain's global lastSimStartTime.
  5. The application row then carries the same timestamp.
  6. ComputeMsBetweenSimulationStarts() requires currentSimStartTime > lastSimStartTime, so the application row also emits no interval.

Repeating this sequence may leave the capture with no valid simulation interval samples.

Existing test PcLatencyFrameGenerationTests::GeneratedPresentDoesNotTakeApplicationPclData confirms the prerequisite that generated and application presents can receive the same PCL timestamp.

When this behavior arose

The underlying simulation interval logic has existed since at least commit ee39f134 on January 5, 2026.

The suspected duplicate-timestamp interaction took its current form in commit 081c989b on November 18, 2026, merged through #725. That change correctly allowed a generated present to read PCL data without claiming it, so the following application present could receive the same data.

Before #725, the generated present could consume the timing entry and leave the application present without PCL data. After #725, both presents can carry the same timestamp, exposing the lastSimStartTime interaction described above.

The existing CSV and frame-query simulation interval surfaces predate #741. That PR only makes the behavior more visible by deriving Simulation FPS and Simulation Frame Time from the same field.

Validation plan

End-to-end unit test

Construct a generated AMD_FSR_FG present followed by an application present sharing one PCL simulation timestamp, and feed them through UnifiedSwapChain in their expected completion/display order.

Verify that:

  • The generated row has no simulation interval.
  • The application row should produce an interval relative to the previous application marker.
  • Repeated generated/application pairs continue producing application intervals.
  • Missing-marker application frames, dropped frames, XeSS-style ordering, and source transitions do not regress.

This test should exercise actual state updates rather than assigning lastSimStartTime manually.

PresentBench2 experiment

Extend PresentBench2 with optional real FSR-FG support:

  • Add a DX12 --use-fsr-fg mode and capability reporting.
  • Supply FSR-FG depth, motion-vector, and timing inputs.
  • Emit AMD_FSR_FG frame-type events for generated presents.
  • Run with --emit-pcl-markers.
  • Capture ETL and inspect frame type, PCL frame ID, simulation timestamps, MsBetweenSimulationStart, Simulation FPS, and Simulation Frame Time.

Compare frame generation disabled, FSR-FG enabled, and XeSS-FG enabled.

FSR-FG is cross-vendor, so AMD hardware is not inherently required. Use hardware explicitly supported by the selected FSR SDK version.

Fix proposals

Option A: Update simulation history only for application work

Prevent generated-only rows from advancing lastSimStartTime. Application frames without markers should continue leaving the previous valid marker intact.

This is the smallest fix, but all other users of lastSimStartTime must be audited.

Option B: Track application simulation history separately

Add a dedicated lastAppSimStartTime, update it only from application frames with valid markers, and use it for msBetweenSimStarts.

This avoids changing other consumers of lastSimStartTime and is likely safer, but requires coordinated V1, V2, bootstrap, dropped-frame, and reset handling.

Acceptance criteria

  • Generated rows remain missing for application simulation interval metrics.
  • Each marked application frame after initialization produces a valid interval.
  • No CPU fallback is introduced.
  • Missing markers do not erase prior valid application marker history.
  • Existing PC latency, animation, XeSS-FG, CSV, and frame-query behavior does not regress.
  • Unit coverage and a live or PresentBench2 ETL confirm the result.
Lenguaje dominante
C++
Estrellas
2.6k
Forks
201
Merge medio
2 d 21 h
PR fusionados (30 d)
16

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de GameTechDev/PresentMon

Todos los issues de GameTechDev/PresentMon

Issues similares

Más issues de C++

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.