Honor forwarded headers when creating management URLs

Aberta
  • Algo errado?
#618 1 comentário 0 reações 0 responsáveis Ver no GitHub

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
62/100
Tipo de issue
Bug
Clareza
Razoavelmente clara
Status de atividade
Pouca atividade
Stack de tecnologia
azure, python
Domínio
api, backend

Direção de pesquisa

Comece em azure/durable_functions/models/DurableOrchestrationClient.py lendo get_client_response_links() e _replace_url_origin(). Use a reprodução no nível do código-fonte do issue para rastrear como request.url substitui a origem da URL de gerenciamento e, em seguida, inspecione o comportamento esperado de opt-in dos headers encaminhados. Está concluído quando headers Forwarded ou X-Forwarded confiáveis produzirem o esquema e o host voltados para o cliente, enquanto o comportamento padrão permanece inalterado.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Enhancement fixed-in-v2 P3

🐛 Describe the bug

A clear and concise description of what the bug is.

DurableOrchestrationClient.create_check_status_response() and get_client_response_links() do not consider Forwarded, X-Forwarded-Host, or X-Forwarded-Proto when constructing management URLs.

The SDK copies the extension-provided management URL templates, then unconditionally replaces their origin with the scheme and authority from request.url. Behind Azure Front Door, Application Gateway, or another reverse proxy, request.url can contain the internal origin. The resulting Location, statusQueryGetUri, and other management URLs can therefore expose an internal hostname or use HTTP even when forwarded headers describe the public HTTPS origin.

The Durable Functions extension added opt-in forwarded-header support in Azure/azure-functions-durable-extension#3083. Out-of-process binding templates are generated without an HTTP request, however, and the Python SDK subsequently replaces their origin from request.url, so that extension behavior does not cover this Python path.

This is separate from #355: current Azure Linux managed hosting correctly returns HTTPS management URLs for ordinary HTTPS-only Function Apps.

🤔 Expected behavior

What should have happened?

When trusted forwarded-header handling is enabled, Python-generated management URLs should use the client-facing scheme and host from Forwarded or X-Forwarded-Proto/X-Forwarded-Host, consistent with the Durable Functions extension behavior. Without opt-in, existing request.url behavior should remain unchanged.

☕ Steps to reproduce

What Durable Functions patterns are you using, if any?
Any minimal reproducer we can use?
Are you running this locally or on Azure?

  1. Run a Python Durable Functions HTTP starter behind a reverse proxy.
  2. Have the proxy forward a public HTTPS origin using X-Forwarded-Proto: https and X-Forwarded-Host: public.example.com, while the worker receives an internal request.url such as http://internal.example/api/start.
  3. Return client.create_check_status_response(req, instance_id).
  4. Observe that the management URL origins use http://internal.example rather than https://public.example.com.

A source-level reproduction is also sufficient: initialize the client with an HTTPS management URL template, call get_client_response_links() with an HTTP request.url, and observe that _replace_url_origin() downgrades the template to HTTP.

Relevant implementation: azure/durable_functions/models/DurableOrchestrationClient.py, in get_client_response_links() and _replace_url_origin().

⚡If deployed to Azure

We have access to a lot of telemetry that can help with investigations. Please provide as much of the following information as you can to help us investigate!

  • Timeframe issue observed: N/A; identified through source analysis of reverse-proxy behavior
  • Function App name: N/A
  • Function name(s): N/A
  • Azure region: N/A
  • Orchestration instance ID(s): N/A
  • Azure storage account name: N/A

If you don't want to share your Function App or storage account name GitHub, please at least share the orchestration instance ID. Otherwise it's extremely difficult to look up information.

Linguagem predominante
Python
Estrelas
157
Forks
71
Nenhum PR com merge em 30d

Preparar o ambiente

Abrir no Codespaces

Inicia o contêiner de desenvolvimento do projeto no navegador, com a sua própria conta do GitHub.

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de Azure/azure-functions-durable-python

Todas as issues de Azure/azure-functions-durable-python

Issues semelhantes

Mais issues de Python

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.