Honor forwarded headers when creating management URLs
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 62/100
Direzione di ricerca
Inizia in azure/durable_functions/models/DurableOrchestrationClient.py leggendo get_client_response_links() e _replace_url_origin(). Usa la riproduzione a livello di codice sorgente dell’issue per tracciare come request.url sostituisce l’origine dell’URL di gestione, quindi esamina il comportamento previsto di opt-in per gli header inoltrati. È completato quando gli header Forwarded o X-Forwarded attendibili producono lo schema e l’host visibili al client, mentre il comportamento predefinito rimane invariato.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
🐛 Describe the bug
A clear and concise description of what the bug is.
DurableOrchestrationClient.create_check_status_response() and get_client_response_links() do not consider Forwarded, X-Forwarded-Host, or X-Forwarded-Proto when constructing management URLs.
The SDK copies the extension-provided management URL templates, then unconditionally replaces their origin with the scheme and authority from request.url. Behind Azure Front Door, Application Gateway, or another reverse proxy, request.url can contain the internal origin. The resulting Location, statusQueryGetUri, and other management URLs can therefore expose an internal hostname or use HTTP even when forwarded headers describe the public HTTPS origin.
The Durable Functions extension added opt-in forwarded-header support in Azure/azure-functions-durable-extension#3083. Out-of-process binding templates are generated without an HTTP request, however, and the Python SDK subsequently replaces their origin from request.url, so that extension behavior does not cover this Python path.
This is separate from #355: current Azure Linux managed hosting correctly returns HTTPS management URLs for ordinary HTTPS-only Function Apps.
🤔 Expected behavior
What should have happened?
When trusted forwarded-header handling is enabled, Python-generated management URLs should use the client-facing scheme and host from Forwarded or X-Forwarded-Proto/X-Forwarded-Host, consistent with the Durable Functions extension behavior. Without opt-in, existing request.url behavior should remain unchanged.
☕ Steps to reproduce
What Durable Functions patterns are you using, if any?
Any minimal reproducer we can use?
Are you running this locally or on Azure?
- Run a Python Durable Functions HTTP starter behind a reverse proxy.
- Have the proxy forward a public HTTPS origin using
X-Forwarded-Proto: httpsandX-Forwarded-Host: public.example.com, while the worker receives an internalrequest.urlsuch ashttp://internal.example/api/start. - Return
client.create_check_status_response(req, instance_id). - Observe that the management URL origins use
http://internal.examplerather thanhttps://public.example.com.
A source-level reproduction is also sufficient: initialize the client with an HTTPS management URL template, call get_client_response_links() with an HTTP request.url, and observe that _replace_url_origin() downgrades the template to HTTP.
Relevant implementation: azure/durable_functions/models/DurableOrchestrationClient.py, in get_client_response_links() and _replace_url_origin().
⚡If deployed to Azure
We have access to a lot of telemetry that can help with investigations. Please provide as much of the following information as you can to help us investigate!
- Timeframe issue observed: N/A; identified through source analysis of reverse-proxy behavior
- Function App name: N/A
- Function name(s): N/A
- Azure region: N/A
- Orchestration instance ID(s): N/A
- Azure storage account name: N/A
If you don't want to share your Function App or storage account name GitHub, please at least share the orchestration instance ID. Otherwise it's extremely difficult to look up information.
- Lingua principale
- Python
- Stelle
- 157
- Fork
- 70
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Preparare l'ambiente
Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.
- Nessun Dockerfile né file Docker Compose
- Nessun modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di Azure/azure-functions-durable-python
-
Enhancement fixed-in-v2 P3
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
Azure/azure-functions-durable-python#617 · 1 commento ·
-
bug Debuggability fixed-in-v2 P2
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
Azure/azure-functions-durable-python#587 · 2 commenti · 1 reazione ·
-
Custom object serialization broken for orchestrator return valuesForse già presa @andystaples l’ha presa 69 giorni fa. Apertabug fixed-in-v2 P2
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
Azure/azure-functions-durable-python#568 · 1 commento ·
-
bug fixed-in-v2 P3
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
Azure/azure-functions-durable-python#475 · 1 commento ·
-
blocked bug fixed-in-v2 known-regression
Difficoltà 4/5 3-5 giorni Idoneità per principianti 45/100
Azure/azure-functions-durable-python#600 · 3 commenti ·
Tutte le issue di Azure/azure-functions-durable-python
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
Graphify-Labs/graphify#4241 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 72/100
-
DeviceTrackerAperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 63/100
XiaoMi/ha_xiaomi_home#1821 ·
I maintainer di solito rispondono entro 1 giorno
-
Maven path-index: "Ambiguous or noncanonical artifact path" error does not report the offending pathAperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
pulp/pulp_maven#524 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 1/5 1-3 ore Idoneità per principianti 82/100
I maintainer di solito rispondono entro 1 giorno