Hacktoberfest 2026: as issues que os mantenedores marcaram para outubro, abertas e boas para iniciantes. Ver issues do Hacktoberfest

Review follow-ups for the dbt e2e cache, CI comments, skill-sync test and run --model

Aberta
  • Algo errado?
#1,473 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
48/100
Tipo de issue
Bug
Clareza
Razoavelmente clara
Status de atividade
Ativa
Stack de tecnologia
github-actions, python, shell, typescript
Domínio
ci-cd, cli, testing

Direção de pesquisa

This bundles six small fixes across packages/dbt-tools/test/e2e/setup-versions.sh, dbt-versions.test.ts, the e2e README, .github/workflows/ci.yml, the run --model error path, and the skill-sync test. Start with the installed_version() function and the venv check in the shell script, and the empty-entry parsing of DBT_E2E_VERSIONS in the TypeScript test. Pick one item at a time; done means each listed behaviour is fixed and the affected tests pass.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

bug

What

Review follow-ups from #1258, #1469, #1470 and #1472, which merged without them:

  1. packages/dbt-tools/test/e2e/setup-versions.sh (#1258)
    • installed_version() runs dbt --version with no time limit, so a dbt that hangs stalls setup until the job times out.
    • A venv directory without bin/dbt (an interrupted install) is skipped instead of rebuilt, and a fresh install is never checked against the version asked for.
    • The usage text still names ./e2e-setup.sh.
  2. packages/dbt-tools/test/e2e/dbt-versions.test.ts (#1258)
    • With no versioned venvs, the system-dbt fallback passes the first python3 on PATH as pythonPath, which may belong to a different dbt than the one under test.
    • An empty entry in DBT_E2E_VERSIONS ("1.8,", or only commas) counts as a requested version named "".
  3. packages/dbt-tools/test/e2e/README.md (#1258) describes the old CI setup and does not document DBT_E2E_VERSIONS or DBT_E2E_PYTHON.
  4. .github/workflows/ci.yml comments (#1469) do not say why runs on main can still show as cancelled: a concurrency group keeps one running and one pending run, and a newer run cancels the pending one.
  5. run --model (#1472): when the provider-list call fails, the error body is described with JSON.stringify, which throws on a cyclic object or a BigInt. The message about the failure is then lost behind a TypeError.
  6. The skill-sync test added in #1470 does not check the row the link leaves behind (its linkedAt, and that it is not marked adopted).

Suggested fix

  • Bound dbt --version with timeout/gtimeout, rebuild any existing venv whose dbt does not report the expected version, and fail setup when a fresh install reports the wrong one. Update the README and usage text.
  • Filter empty entries out of DBT_E2E_VERSIONS, and take pythonPath from the directory of the resolved system dbt, falling back to python3 on PATH.
  • Name the concurrency behaviour in the ci.yml comment.
  • Fall back to String(error) when JSON.stringify throws.
  • Assert the linked row's linkedAt and that it is not adopted.
Linguagem predominante
TypeScript
Estrelas
812
Forks
123
Merge médio
1d 16h
PRs com merge (30d)
81

Preparar o ambiente

Abrir no Codespaces

Inicia o contêiner de desenvolvimento do projeto no navegador, com a sua própria conta do GitHub.

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de AltimateAI/altimate-code

Todas as issues de AltimateAI/altimate-code

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.