Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Review follow-ups for the dbt e2e cache, CI comments, skill-sync test and run --model

Abierto
  • ¿Algo no está bien?
#1,473 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
48/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
github-actions, python, shell, typescript
Área
ci-cd, cli, testing

Línea de trabajo

This bundles six small fixes across packages/dbt-tools/test/e2e/setup-versions.sh, dbt-versions.test.ts, the e2e README, .github/workflows/ci.yml, the run --model error path, and the skill-sync test. Start with the installed_version() function and the venv check in the shell script, and the empty-entry parsing of DBT_E2E_VERSIONS in the TypeScript test. Pick one item at a time; done means each listed behaviour is fixed and the affected tests pass.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug

What

Review follow-ups from #1258, #1469, #1470 and #1472, which merged without them:

  1. packages/dbt-tools/test/e2e/setup-versions.sh (#1258)
    • installed_version() runs dbt --version with no time limit, so a dbt that hangs stalls setup until the job times out.
    • A venv directory without bin/dbt (an interrupted install) is skipped instead of rebuilt, and a fresh install is never checked against the version asked for.
    • The usage text still names ./e2e-setup.sh.
  2. packages/dbt-tools/test/e2e/dbt-versions.test.ts (#1258)
    • With no versioned venvs, the system-dbt fallback passes the first python3 on PATH as pythonPath, which may belong to a different dbt than the one under test.
    • An empty entry in DBT_E2E_VERSIONS ("1.8,", or only commas) counts as a requested version named "".
  3. packages/dbt-tools/test/e2e/README.md (#1258) describes the old CI setup and does not document DBT_E2E_VERSIONS or DBT_E2E_PYTHON.
  4. .github/workflows/ci.yml comments (#1469) do not say why runs on main can still show as cancelled: a concurrency group keeps one running and one pending run, and a newer run cancels the pending one.
  5. run --model (#1472): when the provider-list call fails, the error body is described with JSON.stringify, which throws on a cyclic object or a BigInt. The message about the failure is then lost behind a TypeError.
  6. The skill-sync test added in #1470 does not check the row the link leaves behind (its linkedAt, and that it is not marked adopted).

Suggested fix

  • Bound dbt --version with timeout/gtimeout, rebuild any existing venv whose dbt does not report the expected version, and fail setup when a fresh install reports the wrong one. Update the README and usage text.
  • Filter empty entries out of DBT_E2E_VERSIONS, and take pythonPath from the directory of the resolved system dbt, falling back to python3 on PATH.
  • Name the concurrency behaviour in the ci.yml comment.
  • Fall back to String(error) when JSON.stringify throws.
  • Assert the linked row's linkedAt and that it is not adopted.
Lenguaje dominante
TypeScript
Estrellas
810
Forks
121
Merge medio
1 d 10 h
PR fusionados (30 d)
89

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de AltimateAI/altimate-code

Todos los issues de AltimateAI/altimate-code

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.