`<relabel_config>` -> <relabel_action> description not comlete for `drop` and `keep`
Maintainers usually reply within 4 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 65/100
- Issue type
- Documentation
- Clarity
- Mostly clear
- Activity status
- Stale
- Domain
- documentation
Research direction
Start with the relabel_config section at the linked Prometheus configuration documentation page and compare the keep and drop descriptions with metric_relabel_configs. Update the wording so it covers both targets and metrics, then verify that the descriptions no longer imply they apply only to targets.
Written by the indexing model from the issue text.
Description
From https://prometheus.io/docs/prometheus/latest/configuration/configuration/#relabel_config:
keep: Drop targets for which regex does not match the concatenated source_labels.
drop: Drop targets for which regex matches the concatenated source_labels.
This incorrectly says that drop/keep is only to drop targets, when it is also to drop/keep metrics when used with <metric_relabel_configs>
This is slightly related to https://github.com/prometheus/docs/issues/341, but https://github.com/prometheus/docs/issues/341 says that relabel_config is accurate which is not true.
- Dominant language
- TypeScript
- Stars
- 718
- Forks
- 1.2k
- Avg merge
- 4d 16h
- Merged PRs (30d)
- 19
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from prometheus/docs
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
prometheus/docs#2285 ·
Maintainers usually reply within 4 days
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
prometheus/docs#2171 ·
Maintainers usually reply within 4 days
-
better 404 pagePossibly taken @aryansk claimed this 59 days ago. Opengood first issue priority/p3 site
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
prometheus/docs#1795 · 2 comments ·
Maintainers usually reply within 4 days
-
Needs example of cluster wide inhibitionMay be free again A pull request for this issue was closed without being merged. Opendiataxis/howto
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
prometheus/docs#1353 · 5 comments ·
Maintainers usually reply within 4 days
-
kind/enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
prometheus/docs#836 · 3 comments · 38 reactions ·
Maintainers usually reply within 4 days
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
OHDSI/Data2Evidence#3496 ·
Maintainers usually reply within 2 days
-
TaskSecret.vue: replace explicit `any` with real typesPossibly taken @prayas-bit claimed this today. Openarea/frontend good first issue kind/cooldown
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
kestra-io/kestra#20352 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day