fluent.syntax.ast.Visitor could use `ignore_fields` option

Open
#103 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
internationalization

Research direction

Start by locating fluent.syntax.ast.BaseNode.equals and the Visitor implementation, then inspect how Visitor enumerates properties before reaching Span or Annotation nodes. Add the ignore_fields behavior at that enumeration point and verify that annotations and spans are skipped while other properties remain visited.

Written by the indexing model from the issue text.

Description

fluent.syntax

In BaseNode.equals, we have an ignore_fields option. That'd also be nice for Visitor, as it would allow a visitor to skip annotations and spans at the point of enumerating the properties, which is one or two cycles before actually going in to the Span or Annotation nodes, where we can handle them right now.

Dominant language
Python
Stars
245
Forks
30
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from projectfluent/python-fluent

All issues in projectfluent/python-fluent

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.