[Bug]: Add provider can create a built-in driver's default instance, which has no delete action
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 77/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- react, typescript
- Domain
- frontend
Research direction
Start with AddProviderInstanceDialog.tsx and ProviderSettingsPanel.tsx, then trace how defaultInstanceIdForDriver and ProviderInstanceRegistryHydration.deriveProviderInstanceConfigMap identify default instances. Reproduce with a built-in provider whose label is unchanged and inspect the existing tests for provider instance creation and deletion. Done when a provider added through the dialog has a clear delete action and the regression is covered.
Written by the indexing model from the issue text.
Description
What happened
I added four providers through Settings → Providers → Add provider: Pi, Cursor, Antigravity and Kiro. All four now appear in Settings, but none of them has a delete action. Their detail pane only offers "Reset provider settings to default". Instances I added with a custom ID, such as a second Claude account or an ACP Registry agent, do show the trash / "Delete instance" action.
Why this happens
- Add provider pre-fills the label with the provider's label and derives the instance ID from that label. When the label still equals the provider label,
AddProviderInstanceDialog.tsxreturns the driver ID itself (pi,cursor,antigravity,kiro, …). ItsexistingIdsset only reservescodexandclaudeAgent, so those driver IDs are accepted. - That ID is exactly what
defaultInstanceIdForDriverreturns for the driver, andProviderInstanceRegistryHydration.deriveProviderInstanceConfigMapalways adds a default instance for every built-in driver. The created entry is therefore treated as the driver's default slot, not as an added instance. ProviderSettingsPanel.tsxmarks any instance whose ID equals the default ID asisDefault, and only passesonDeletefor non-default rows.ProviderInstanceCardrenders the trash button only whenonDeleteis set; default rows get the Reset button instead.- Reset does remove the stored entry, but the button and its confirmation only say "Reset … to its defaults", so nothing tells the user it is the only removal path. The row is also the only place that provider can be managed.
Steps to reproduce
- Open Settings → Providers.
- Click Add provider, choose Pi (or Cursor, Antigravity, Kiro), leave the label unchanged, click Next and Add instance.
- Select the new row and open its detail pane.
- Only "Reset Pi provider settings" is shown. There is no Delete / trash action.
- Clicking Reset asks to reset the provider to its defaults, not to remove it.
Expected behavior
A provider created through Add provider should be deletable like any other added instance. Either the dialog should not derive a built-in driver's default ID for new instances, or a default-slot row with an explicit stored config should also offer Delete.
Actual behavior
The created rows are reset-only and are indistinguishable from built-in defaults, so they look like providers that cannot be deleted.
Version
T3 Code 0.1.9 (desktop), macOS 27.0 arm64. The same code is on main today: AddProviderInstanceDialog.tsx still reserves only codex and claudeAgent, and ProviderSettingsPanel.tsx still renders onDelete only for !isDefault.
- Dominant language
- TypeScript
- Stars
- 24.8k
- Forks
- 6.4k
- Avg merge
- 4h 46m
- Merged PRs (30d)
- 488
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from pingdotgg/t3code
-
bug needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
bug needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
pingdotgg/t3code#38462 · 3 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
Maintainers usually reply within 1 day
All issues in pingdotgg/t3code
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
solidjs/solid-docs#1716 ·
Maintainers usually reply within 1 day
-
Progress indicated by console logs is off by onePossibly taken @marceliwac claimed this today. Openbug needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
aws-samples/aws-cdk-examples#1336 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
melgarafael/DeskcommCRM#4999 · 1 comment ·
Maintainers usually reply within 1 day
-
type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
db-ux-design-system/core-web#8856 ·
Maintainers usually reply within 1 day